Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12013 rds exporter #3057

Open
wants to merge 7 commits into
base: v3
Choose a base branch
from
Open

PMM-12013 rds exporter #3057

wants to merge 7 commits into from

Conversation

BupycHuk
Copy link
Member

@BupycHuk BupycHuk commented Jul 5, 2024

PMM-12013

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@BupycHuk BupycHuk requested review from a team as code owners July 5, 2024 13:06
@BupycHuk BupycHuk requested review from ademidoff, idoqo and JiriCtvrtka and removed request for a team July 5, 2024 13:06
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 58.97436% with 16 lines in your changes missing coverage. Please review.

Project coverage is 44.62%. Comparing base (fb8105a) to head (b9712ef).

Files Patch % Lines
managed/services/agents/state.go 0.00% 12 Missing ⚠️
managed/services/management/rds.go 71.42% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3057      +/-   ##
==========================================
- Coverage   44.64%   44.62%   -0.03%     
==========================================
  Files         358      358              
  Lines       35630    35647      +17     
==========================================
  Hits        15908    15908              
- Misses      18097    18115      +18     
+ Partials     1625     1624       -1     
Flag Coverage Δ
admin 11.52% <ø> (ø)
agent 52.60% <ø> (-0.14%) ⬇️
managed 46.86% <58.97%> (+0.01%) ⬆️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	api/managementpb/json/client/rds/add_rds_responses.go
#	api/managementpb/json/managementpb.json
#	api/managementpb/rds.pb.go
#	api/swagger/swagger-dev.json
#	api/swagger/swagger.json
#	managed/services/management/rds.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants