PMM-12573 Update podman via UI. #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #3128 +/- ##
==========================================
- Coverage 43.42% 43.42% -0.01%
==========================================
Files 360 360
Lines 43947 43977 +30
==========================================
+ Hits 19084 19096 +12
- Misses 23203 23219 +16
- Partials 1660 1662 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BupycHuk
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
BupycHuk
commented
Aug 6, 2024
| @@ -1,5 +1,5 @@ | |||
| PMM_WATCHTOWER_HOST=http://watchtower:8080 | |||
| PMM_WATCHTOWER_TOKEN=123 | |||
| PMM_SERVER_UPDATE_VERSION=docker.io/perconalab/pmm-server:3-dev-container | |||
| PMM_DEV_UPDATE_DOCKER_IMAGE=docker.io/perconalab/pmm-server:3-dev-container | |||
There was a problem hiding this comment.
it will be dropped before GA
| @@ -409,6 +423,27 @@ func (up *Updater) checkWatchtowerHost() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (up *Updater) updateEnvironmentVariables(filename string, name string) error { | |||
| if len(strings.Split(name, "/")) < 3 { | |||
| name = "docker.io/" + name | |||
There was a problem hiding this comment.
podman requires full name to update.
idoqo
approved these changes
Aug 6, 2024
JiriCtvrtka
reviewed
Aug 6, 2024
| @@ -1,5 +1,5 @@ | |||
| PMM_WATCHTOWER_HOST=http://watchtower:8080 | |||
| PMM_WATCHTOWER_TOKEN=123 | |||
| PMM_SERVER_UPDATE_VERSION=docker.io/perconalab/pmm-server:3-dev-container | |||
| PMM_DEV_UPDATE_DOCKER_IMAGE=docker.io/perconalab/pmm-server:3-dev-container | |||
| PMM_IMAGE={{ pmm_server_image_name }} | |||
| PMM_DISTRIBUTION_METHOD={{ pmm_distribution_method }} | |||
There was a problem hiding this comment.
Just small thing there is missing empty line at end of file.
JiriCtvrtka
reviewed
Aug 6, 2024
| PMM_WATCHTOWER_HOST=http://watchtower:8080 | ||
| PMM_WATCHTOWER_TOKEN=123 | ||
| PMM_IMAGE=docker.io/perconalab/pmm-server:3-dev-latest | ||
| PMM_DISTRIBUTION_METHOD=ami |
There was a problem hiding this comment.
Just small thing there is missing empty line at end of file.
JiriCtvrtka
approved these changes
Aug 6, 2024
idoqo
approved these changes
Aug 13, 2024
ademidoff
force-pushed
the
v3
branch
2 times, most recently
from
4b06c24
to
6a7efaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12573
Link to the Feature Build: SUBMODULES-3682
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: