Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13146 Fix v3 telemetry issues #3154

Merged
merged 16 commits into from
Sep 16, 2024
Merged

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Aug 15, 2024

PMM-13146

Link to the Feature Build: SUBMODULES-3692

@ademidoff ademidoff changed the base branch from main to v3 August 15, 2024 10:23
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.47%. Comparing base (5561f58) to head (019e468).
Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
managed/utils/envvars/parser.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3154      +/-   ##
==========================================
- Coverage   44.51%   44.47%   -0.05%     
==========================================
  Files         357      357              
  Lines       35670    35577      -93     
==========================================
- Hits        15880    15824      -56     
+ Misses      18163    18129      -34     
+ Partials     1627     1624       -3     
Flag Coverage Δ
managed 46.65% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff force-pushed the PMM-13146-fix-v3-telemetry-issues branch from cd0e3d0 to 422d5b4 Compare August 15, 2024 11:56
@ademidoff ademidoff marked this pull request as ready for review August 20, 2024 08:32
@ademidoff ademidoff requested a review from a team as a code owner August 20, 2024 08:32
@ademidoff ademidoff requested review from idoqo, JiriCtvrtka and BupycHuk and removed request for a team August 20, 2024 08:32
@ademidoff ademidoff requested a review from a team as a code owner August 20, 2024 08:42
docs/process/v2_to_v3_environment_variables.md Outdated Show resolved Hide resolved
managed/services/telemetry/config.default.yml Outdated Show resolved Hide resolved
managed/services/telemetry/config.default.yml Show resolved Hide resolved
managed/services/telemetry/config.default.yml Outdated Show resolved Hide resolved
managed/services/telemetry/config.default.yml Outdated Show resolved Hide resolved
managed/services/telemetry/config.default.yml Outdated Show resolved Hide resolved
managed/utils/envvars/parser.go Show resolved Hide resolved
@ademidoff ademidoff force-pushed the PMM-13146-fix-v3-telemetry-issues branch 2 times, most recently from e918913 to d8ab901 Compare August 20, 2024 20:17
@ademidoff ademidoff force-pushed the PMM-13146-fix-v3-telemetry-issues branch from d8ab901 to 597dd2d Compare August 20, 2024 20:19
@ademidoff ademidoff enabled auto-merge (squash) September 16, 2024 09:27
@ademidoff ademidoff merged commit 8ad46db into v3 Sep 16, 2024
13 checks passed
@ademidoff ademidoff deleted the PMM-13146-fix-v3-telemetry-issues branch September 16, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants