PMM-13314 Add flag to control adding yum repo in initialization procedure #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konopka90
requested review from
BupycHuk,
talhabinrizwan and
a team
as code owners
konopka90
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
|
|
Draft
1 task
|
looks like a great idea, but I believe it should be read from environment variable, so it's easy to change value when you start container. |
Thanks for a comment, I will update it |
|
I signed CLA but it still shows wrong status. Is it possible to fix it ? edit: |
konopka90
force-pushed
the
PMM-13314-add-yum-flag
branch
from
d385b84
to
117bbd9
Compare
ademidoff
requested changes
Aug 26, 2024
| @@ -10,6 +10,8 @@ | |||
| gpgcheck: yes | |||
| enabled: yes | |||
| gpgkey: file:///etc/pki/rpm-gpg/PERCONA-PACKAGING-KEY | |||
| when: | |||
| - lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' | |||
There was a problem hiding this comment.
Suggested change
| - lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' | |
| - lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='false') == 'false' |
| @@ -19,6 +21,8 @@ | |||
| gpgcheck: yes | |||
| enabled: yes | |||
| gpgkey: file:///etc/pki/rpm-gpg/PERCONA-PACKAGING-KEY | |||
| when: | |||
| - lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' | |||
There was a problem hiding this comment.
Suggested change
| - lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' | |
| - lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='false') == 'false' |
| @@ -48,6 +52,8 @@ | |||
| gpgcheck: yes | |||
| enabled: yes | |||
| gpgkey: file:///etc/pki/rpm-gpg/PERCONA-PACKAGING-KEY | |||
| when: | |||
| - lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' | |||
There was a problem hiding this comment.
Suggested change
| - lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' | |
| - lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='false') == 'false' |
| @@ -57,6 +63,8 @@ | |||
| gpgcheck: yes | |||
| enabled: yes | |||
| gpgkey: file:///etc/pki/rpm-gpg/PERCONA-PACKAGING-KEY | |||
| when: | |||
| - lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' | |||
There was a problem hiding this comment.
Suggested change
| - lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='undefined') == 'undefined' | |
| - lookup('env', 'DISABLE_REMOTE_YUM_REPOSITORY', default='false') == 'false' |
…/pmm into PMM-13314-add-yum-flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13314
Link to the Feature Build: SUBMODULES-0
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: