PMM-13348 Fix status presentation. #3200
Open
+39
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BupycHuk
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3200 +/- ##
=======================================
Coverage 43.37% 43.38%
=======================================
Files 399 399
Lines 41698 41702 +4
=======================================
+ Hits 18087 18091 +4
Misses 21595 21595
Partials 2016 2016
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JiriCtvrtka
reviewed
Sep 12, 2024
admin/commands/list.go
Outdated
Comment on lines
68
to
70
| res = strings.ToLower(res) | ||
| res = cases.Title(language.English).String(res) | ||
| res = strings.ReplaceAll(res, "_", " ") |
There was a problem hiding this comment.
Maybe it would be good to extract this into method since it is used in two places. With that we can ensure always same "formatting" in both methods.
JiriCtvrtka
approved these changes
Sep 12, 2024
idoqo
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13348
Link to the Feature Build: SUBMODULES-3708
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: