Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13416 Fix enum flags in pmm-admin. #3236

Merged
merged 17 commits into from
Nov 8, 2024
Merged

Conversation

BupycHuk
Copy link
Member

PMM-13416

Link to the Feature Build: SUBMODULES-3737

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@BupycHuk BupycHuk requested a review from a team as a code owner October 13, 2024 09:50
@BupycHuk BupycHuk requested review from idoqo and JiriCtvrtka and removed request for a team October 13, 2024 09:50
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 23.63636% with 42 lines in your changes missing coverage. Please review.

Project coverage is 43.47%. Comparing base (4266c88) to head (0b883f6).
Report is 5 commits behind head on v3.

Files with missing lines Patch % Lines
managed/services/converters.go 64.28% 5 Missing ⚠️
admin/commands/management/add_mysql.go 0.00% 3 Missing ⚠️
admin/commands/management/add_postgresql.go 0.00% 3 Missing ⚠️
admin/commands/config.go 50.00% 1 Missing and 1 partial ⚠️
.../inventory/add_agent_qan_mysql_perfschema_agent.go 0.00% 2 Missing ⚠️
...nds/inventory/add_agent_qan_mysql_slowlog_agent.go 0.00% 2 Missing ⚠️
...ntory/add_agent_qan_postgres_pgstatements_agent.go 0.00% 2 Missing ⚠️
...tory/add_agent_qan_postgres_pgstatmonitor_agent.go 0.00% 2 Missing ⚠️
admin/commands/management/add_mongodb.go 0.00% 2 Missing ⚠️
admin/commands/management/add_proxysql.go 0.00% 2 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3236      +/-   ##
==========================================
+ Coverage   43.45%   43.47%   +0.01%     
==========================================
  Files         362      365       +3     
  Lines       44123    44105      -18     
==========================================
  Hits        19175    19175              
+ Misses      23264    23246      -18     
  Partials     1684     1684              
Flag Coverage Δ
admin 11.49% <7.69%> (+0.04%) ⬆️
agent 51.80% <0.00%> (ø)
managed 45.22% <66.66%> (ø)
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BupycHuk BupycHuk enabled auto-merge (squash) November 7, 2024 09:30
@BupycHuk BupycHuk merged commit 14242e8 into v3 Nov 8, 2024
32 checks passed
@BupycHuk BupycHuk deleted the PMM-13416-fix-enum-in-pmm-admin branch November 8, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants