PMM-13373 Different QAN max query length for MongoDB. #3273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #3273 +/- ##
=======================================
Coverage 43.41% 43.41%
=======================================
Files 360 360
Lines 43979 43981 +2
=======================================
+ Hits 19093 19095 +2
Misses 23224 23224
Partials 1662 1662
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JiriCtvrtka
force-pushed
the
PMM-13373-QAN-mongo-query-length
branch
from
9c1b7fa
to
331415c
Compare
1 task
JiriCtvrtka
requested review from
ademidoff and
idoqo
and removed request for
a team
idoqo
approved these changes
Oct 30, 2024
BupycHuk
reviewed
Oct 30, 2024
agent/utils/truncate/query.go
Outdated
Comment on lines
33
to
35
| // MongoQuery truncate query to specific length of chars, if needed. -1: No limit, 0: Default (4096). | ||
| // Also truncate all invalid UTF-8 chars. | ||
| func MongoQuery(q string, maxQueryLength int32) (string, bool) { |
There was a problem hiding this comment.
do we really need it to be a separate function instead of 3rd parameter?
There was a problem hiding this comment.
No we dont, but for me it looked more clear. Also it has less affected files. Changed back to one func with 3 params.
ademidoff
approved these changes
Oct 31, 2024
BupycHuk
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13373
Link to the Feature Build: Percona-Lab/pmm-submodules#3751