PG-1879 More cleanup of the Makefile before we split the repo #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move the first item to a separate line. This improves readability of the Makefile while also making it more like PG's own makefiles.
Writing the whole compiler command from scratch only makes it more risky that we miss something.
Using many different variables only makes things more confusing and when we start needing to use $(libpq_pgport) this will be cleaner anyway.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (84.20%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #586 +/- ##
==================================================
Coverage 84.20% 84.20%
==================================================
Files 25 25
Lines 3247 3247
Branches 511 511
==================================================
Hits 2734 2734
Misses 400 400
Partials 113 113
🚀 New features to boost your workflow:
|
dAdAbird
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the following things:
xlogreader.o