PS-10085 MyRocks limitations section still showing the Online DDL limitation part (8.0) #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alina-derkach-oaza
force-pushed
the
PS-10085
branch
from
d25fc52 to
09077ea
Compare
alina-derkach-oaza
force-pushed
the
PS-10085
branch
from
09077ea to
357adc8
Compare
inikep
reviewed
Sep 15, 2025
alina-derkach-oaza
force-pushed
the
PS-10085
branch
from
357adc8 to
58be605
Compare
it-percona
temporarily deployed
to
PS-10085 - percona-server-docs-8.0 PR #557
Render
Destroyed
…itation part modified: docs/limitations.md
alina-derkach-oaza
force-pushed
the
PS-10085
branch
from
58be605 to
005192b
Compare
alina-derkach-oaza
force-pushed
the
PS-10085
branch
from
ea313d9 to
31e5846
Compare
alina-derkach-oaza
force-pushed
the
PS-10085
branch
from
31e5846 to
c8dac0f
Compare
inikep
suggested changes
Oct 3, 2025
| | [`rocksdb_enable_instant_ddl_for_drop_index_changes=ON`](variables.md#rocksdb_enable_instant_ddl_for_drop_index_changes) | `ALTER TABLE ... DROP INDEX` | `INSTANT` | | ||
| | [`rocksdb_enable_instant_ddl_for_table_comment_changes=ON`](variables.md#rocksdb_enable_instant_ddl_for_table_comment_changes) | `ALTER TABLE ... COMMENT` | `INSTANT` | | ||
|
|
||
| **Note:** MyRocks does **not support `ALGORITHM=INSTANT`** in SQL syntax. These operations behave like Instant DDL **internally**, but only if the respective configuration variables are enabled. |
There was a problem hiding this comment.
This is not true anymore. ALGORITHM=INSTANT is required for to use INSTANT DDLs e.g.:
1. rocksdb_enable_instant_ddl_for_table_comment_changes=ON
2. ALTER TABLE … COMMENT …, ALGORITHM=INSTANT;
Without ALGORITHM=INSTANT, ALTER TABLE will use default ALGORITHM even if rocksdb_enable_instant_ddl_for_table_comment_changes = ON.
With rocksdb_enable_instant_ddl_for_table_comment_changes=OFF, using ALGORITHM=INSTANT will cause error.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified: docs/limitations.md