ci: make ansible-lint gate (remove '|| true') - #60
Merged
Conversation
michaelcoburn
force-pushed
the
fix/ansible-lint-gate
branch
from
June 2, 2026 18:25
e2d6c92 to
15e43be
Compare
The ansible-lint job ran with `ansible-lint hosts.yml roles/ || true`, so it always passed regardless of findings. Drop `|| true` so the job fails on genuine syntax/load errors. The existing .ansible-lint warn_list keeps the noisy stylistic rules non-blocking, so only real errors break the build. Depends on percona#63 (fixes the malformed percona-repo.yml that would otherwise trip this gate). Merge percona#63 first. Closes percona#59
michaelcoburn
force-pushed
the
fix/ansible-lint-gate
branch
from
June 2, 2026 18:38
15e43be to
96b40c0
Compare
michaelcoburn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59 · depends on #63 — merge that first.
The
ansible-lintjob ran withansible-lint hosts.yml roles/ || true, so it always passed regardless of findings — a check that can't fail is decorative. This drops|| trueso the job gates on genuine syntax/load errors. The existing.ansible-lintwarn_listkeeps the noisy stylistic rules non-blocking, so only real errors break the build.This PR's
ansible-lintcheck will be red until #63 merges — #63 fixes the malformedpercona-repo.ymlthat the gate (correctly) trips on. Sequence:mainbecomes lint-clean.main→ansible-lintgoes green → merge.(Previously this PR bundled both the fix and the gate; split per review so each PR does one thing.)