feat: enable adaptive retries on all AWS SDK clients - #68
Merged
Conversation
AWS API calls (launching instances, tagging, VPC ops, DynamoDB sync) had no explicit retry/backoff config, so transient throttling (RequestLimitExceeded) or blips could abort a run mid-provision and leave the environment half-built. Set 'retries' => ['mode' => 'adaptive', 'max_attempts' => 10] on every EC2 and DynamoDB client (start-instances.php x3, setup-vpc.php, dynamo.php). Adaptive mode adds client-side rate limiting, which is well-suited to the bursty runInstances/describeInstances calls when launching many teams. Verified the config is accepted and a live LISTAMIS call works. Closes percona#54 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54
AWS API calls had no explicit retry/backoff configuration, so transient throttling (
RequestLimitExceeded) or network blips could abort a run mid-provision and leave a half-built environment.Sets
'retries' => ['mode' => 'adaptive', 'max_attempts' => 10]on every EC2 and DynamoDB client:start-instances.php(main$ec2,$dynamo, and theprintAmis$ec2)setup-vpc.php($ec2)dynamo.php($dynamo)Adaptive mode adds client-side rate limiting, which suits the bursty
runInstances/describeInstancescalls when launching many teams at once.Verification
php -lclean on all three files.LISTAMIScall works.