Skip to content

Fix to ptif image conversion and adding a date-based bulk convert task - #134

Open
ajolipa wants to merge 2 commits into
developfrom
rb/pyramidal-tiff-fixes
Open

Fix to ptif image conversion and adding a date-based bulk convert task#134
ajolipa wants to merge 2 commits into
developfrom
rb/pyramidal-tiff-fixes

Conversation

@ajolipa

@ajolipa ajolipa commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

In this PR

@ajolipa
ajolipa requested a review from blms September 1, 2026 19:48

@blms blms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just one suggested change.

Comment thread lib/tasks/iiif.rake Outdated
Co-authored-by: Ben Silverman <ben.lm.silverman@gmail.com>
@ajolipa
ajolipa requested a review from blms September 1, 2026 21:03
@ajolipa

ajolipa commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Looking great! Just one suggested change.

Suggested change makes sense to me; but then would that reasoning also apply to the other tasks in this file, or at least some of them? (convert_images, convert_images_by_type, convert_images_by_colorspace) Although I suppose those were probably written with the intent to include images that had never yet been converted, whereas in this particular context of fixing the flat TIFFs we only need to target resources that have converted_content? Still the inconsistency between otherwise basically identical tasks feels a bit weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants