Fix CI: bump requires-python to >=3.10#47
Merged
Conversation
CI has been failing on all PRs and on main since April 5 (PR #44 bumped matplotlib>=3.8.0 in the 'viz' extra). uv sync --all-extras refuses to resolve because: - requires-python = '>=3.8' tries to satisfy Python 3.8/3.9 - matplotlib>=3.8.0 only supports Python>=3.9 - matplotlib>=3.10.0 only supports Python>=3.10 - The CI matrix tests Python 3.10/3.11/3.12 anyway Bump requires-python to '>=3.10' to match the actual tested range and the modern matplotlib constraint. Also add Python 3.10/3.11/3.12 classifiers, which were missing. No code changes — verified locally: 307 pytest pass, ruff check and format both clean.
Fix CI 'Ruff lint' step. Workflow does 'uv sync --all-extras --dev' then 'uv run ruff check .' but ruff wasn't in any dependency group, so uv couldn't spawn it. Add a [dependency-groups].dev group with ruff>=0.6.0 (matches the version mj_manipulator uses).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI has been red on all PRs and on main since April 5 (#44 — "Bump dependency lower bounds to resolve Dependabot alerts"). Two separate failures stacked on top of each other:
uv sync --all-extras --devcan't resolve because thevizextra requiresmatplotlib>=3.8.0but modern matplotlib versions dropped Python 3.8/3.9 support, whilerequires-python = ">=3.8"asks for those versions.uv run ruff check .couldn't spawn ruff because it wasn't in any dependency group.Fix
Two small changes to
pyproject.toml:requires-pythonfrom">=3.8"to">=3.10"to match:[3.10, 3.11, 3.12]in.github/workflows/ci.yml)vizextra[dependency-groups].dev = ["ruff>=0.6.0"]souv sync --devinstalls ruff for the lint step.Also added
Programming Language :: Python :: 3.10/3.11/3.12classifiers that were missing from the metadata.Risk
Minimal. No code changes. Anyone pinned to Python 3.8/3.9 was already broken by #44 (the
vizextra simply couldn't install); this PR just makes the reality explicit in the metadata.Verified
uv sync --all-extras --devresolves cleanly, installs ruff 0.15.x.ruff checkandruff format --checkboth clean.Why this matters
Unblocks: