Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Should -Throw to handle expected message with escaped wildcard (backport) #2560

Open
wants to merge 6 commits into
base: rel/5.6.x
Choose a base branch
from

Conversation

johlju
Copy link
Contributor

@johlju johlju commented Aug 23, 2024

PR Summary

This target v5. This resolves #2558 so that when the expected message containing escaped wildcard is output is removes the escaped character so it shows the correct expected message that differ from the actual value.

Part of issue #2558

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@johlju
Copy link
Contributor Author

johlju commented Aug 23, 2024

Okay, that was not correct. Know what I did wrong. Trying again.

@johlju johlju force-pushed the fix/wildcard-escaping-in-message-v5 branch from 655f934 to ad1a1f3 Compare August 23, 2024 12:38
@johlju
Copy link
Contributor Author

johlju commented Aug 23, 2024

Reverted to tag 5.6.1 and rebase to rel/5.6.x. Looks good now.

@johlju johlju changed the title Fix Should -Throw to handle expected message with escaped wildcard Fix Should -Throw to handle expected message with escaped wildcard (backport) Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant