fix: don't treat array datasets as callables - #1848
Open
lazerg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
A dataset of exactly two class strings, such as
->with([Project::class, User::class]), is also a valid PHP callable array when the first class has__callStatic, which every Eloquent model does.DatasetsRepository::processDatasets()runs itsis_callable()check before the iterable handling, so it calledProject::User()rather than using the two values, and the test died inside Eloquent. Arrays are now skipped by that check.One or three values, keyed values, or nested arrays never matched the callable-array shape, which is why only this case failed.
Related:
Fixes #1847