Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build configuration to reflect KGP improvements #102

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

lppedd
Copy link
Contributor

@lppedd lppedd commented Mar 28, 2024

I did a bit of a cleanup of the build scripts.
Removed what wasn't necessary, centralized all dependencies in the root version catalog, and applied a more specific configuration to the JVM target.

@lppedd
Copy link
Contributor Author

lppedd commented Mar 28, 2024

Just as a note for potential improvement: I've seen you build and deploy using multiple runners.
You could simplify it by using only the MacOS host, which can build for all targets.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.30%. Comparing base (2d978a9) to head (2e85763).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #102   +/-   ##
=========================================
  Coverage     85.30%   85.30%           
- Complexity      109      110    +1     
=========================================
  Files            14       14           
  Lines           524      524           
  Branches         89       89           
=========================================
  Hits            447      447           
  Misses           53       53           
  Partials         24       24           
Flag Coverage Δ
unittests 85.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! In general, LGTM. I didn't pay too much attention to recent features of KGP.

@lppedd
Copy link
Contributor Author

lppedd commented Mar 28, 2024

Once this PR is merged, I'll submit another one with a bit of code cleanup. No feature changes, just cleanup.
And after that preparation PR, I'll port the algorithm variant.

@petertrr petertrr merged commit b370f69 into petertrr:main Mar 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants