uasyncio.websocket.server: Allow the sending of binary WebSocket frames #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already store that value in .co_flags. Meaning of individual bits may be different from CPython, but the purpose is the same. Proliferating and duplicating fields in codeobj creates more burden and confusion.
pfalcon
force-pushed
the
master
branch
17 times, most recently
from
b23dcb5 to
7f4f102
Compare
pfalcon
force-pushed
the
master
branch
3 times, most recently
from
d87cc03 to
8b11385
Compare
pfalcon
force-pushed
the
master
branch
3 times, most recently
from
9e56005 to
6f45126
Compare
pfalcon
force-pushed
the
master
branch
2 times, most recently
from
5a42161 to
5dd25bc
Compare
pfalcon
force-pushed
the
master
branch
2 times, most recently
from
4e6c1a6 to
d0d19af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I needed to send WebSocket binary frames and I had to change the hardcoded packet header to do so.
I'm not sure if you are interested in this commit. If so, fell free to merge.