Skip to content

WIP: Add GitHub release support for Linux and OSX#66

Open
okapies wants to merge 2 commits into
masterfrom
feature/gh-release
Open

WIP: Add GitHub release support for Linux and OSX#66
okapies wants to merge 2 commits into
masterfrom
feature/gh-release

Conversation

@okapies

@okapies okapies commented Aug 9, 2018

Copy link
Copy Markdown
Member

Ref. https://docs.travis-ci.com/user/deployment/releases/

TODO:

  • Add an archive which contains all dependent shared libraries instead of libmenoh itself
  • Add menoh_onnx_viewer to the package

@okapies okapies requested a review from msakai August 9, 2018 06:12
@msakai

msakai commented Aug 23, 2018

Copy link
Copy Markdown
Contributor

Sorry, I overlooked the review request...

@msakai

msakai commented Aug 23, 2018

Copy link
Copy Markdown
Contributor

It generally looks okay to me.

Some notes:

  • It might be better to package make install/striped version of libraries/executables, but I'm not sure as I'm not very familiar with cmake.
  • For packaging macOS binary, it might be better to specify osx_image: or MACOSX_DEPLOYMENT_TARGET to specify the lower bounds of supported macOS version.

@okapies

okapies commented Aug 23, 2018

Copy link
Copy Markdown
Member Author

Thanks for the comment. I'm inspecting the cmake configuration for static linking. I'll going further after these tasks are finished.

@msakai

msakai commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

Note that now there are multiple jobs for same platform due to #81 and #83.
It is necessary not to upload same file from multiple jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants