tests: add tests on DropDistribution#2172
Merged
Denchick merged 2 commits intopg-sharding:masterfrom Mar 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds unit test coverage around in-memory QDB (MemQDB) distribution deletion behavior, ensuring distributions and their relation mappings are correctly removed and that other distributions are unaffected.
Changes:
- Add a focused set of
DropDistributiontests toqdb/memqdb_test.go(non-existent, empty, with relations, multiple relations, double-drop, isolation vs other dists, list visibility, reattach-after-drop). - Add regression tests for reference-relation prefix-name deletion behavior (issue #1306) in
qdb/memqdb_test.go. - Remove a stale “TODO: unit tests” comment above
EtcdQDB.DropDistribution.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| qdb/memqdb_test.go | Adds new unit tests covering MemQDB.DropDistribution scenarios (+ regression tests for reference relations). |
| qdb/etcdqdb.go | Removes a TODO comment above DropDistribution. |
Denchick
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.