Added Aadi Pandey to contributors #516
Conversation
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…elop/actions/checkout-6 Bump actions/checkout from 5 to 6
pumpup to 4.1.0 dev
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Co-authored-by: Weblate <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/ Translation: pgRouting/pgRouting
…g-develop Translations update from OSGeo Weblate
Currently translated at 100.0% (5383 of 5383 strings) Co-authored-by: Daniel Nylander <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/sv/ Translation: pgRouting/pgRouting
Currently translated at 86.2% (4644 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.2% (4643 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.2% (4641 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4640 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4637 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4636 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4635 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4634 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4633 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4632 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4631 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4630 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4629 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4628 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4627 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4626 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4625 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4624 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4623 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4622 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4621 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4620 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4619 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4618 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4617 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4616 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4615 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4614 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4613 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4612 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4611 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4610 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4609 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4608 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4607 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4605 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4604 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4603 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4602 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4601 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4600 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4599 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4598 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4597 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4596 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4595 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4594 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4593 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.2% (4590 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.2% (4589 of 5383 strings) Co-authored-by: DeepL <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/ Translation: pgRouting/pgRouting
Currently translated at 86.3% (4646 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.2% (4643 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4640 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4635 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4634 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4633 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4632 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4627 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4626 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4622 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4617 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4616 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4613 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4610 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4607 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4605 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4603 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4601 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4600 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4598 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4597 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4595 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4594 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4593 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.2% (4590 of 5383 strings) Co-authored-by: Celia Virginia Vergara Castillo <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/ Translation: pgRouting/pgRouting
Currently translated at 86.3% (4646 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.3% (4650 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.3% (4650 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4651 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4652 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4653 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4653 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4654 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4654 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4655 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4655 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4656 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4656 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.5% (4658 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.5% (4658 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4663 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4663 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4664 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4664 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4665 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4666 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4666 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4667 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.7% (4672 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.7% (4672 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4673 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4674 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4674 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4674 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4675 of 5383 strings) Co-authored-by: Celia Virginia Vergara Castillo <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/ Translation: pgRouting/pgRouting
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Co-authored-by: Weblate <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/ Translation: pgRouting/pgRouting
Currently translated at 87.3% (4700 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 87.3% (4700 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 87.3% (4701 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 87.5% (4714 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 87.5% (4714 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
WalkthroughThis PR releases pgRouting version 4.1.0 by updating version metadata across configuration files, GitHub Actions workflows, documentation, locale files, and by introducing a comprehensive new SQL function signature file with 400+ function declarations. The checkout action is upgraded from v5 to v6 in all workflows, and database setup versions are updated to 4.1.0. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (3)
.github/workflows/clang.yml (1)
58-58: Verify actions/checkout@v6 compatibility.This upgrade from v5 to v6 is consistent with other workflows in this PR. Ensure that the migration to Node.js 20 (required by v6) does not introduce issues with the test environment.
.github/workflows/update-locale.yml (1)
33-33: Verify actions/checkout@v6 compatibility.Consistent with the repo-wide upgrade to checkout@v6.
.github/workflows/release.yml (1)
21-21: Verify actions/checkout@v6 compatibility in the release workflow.Since this is the release workflow, ensuring compatibility with checkout@v6 is particularly important to avoid release failures.
🧹 Nitpick comments (2)
NEWS.md (1)
6-16: LGTM: Release notes section added for version 4.1.0.The new release notes section follows the standard format with a placeholder for future changes. However, note that the PR description is incomplete and should be updated to describe the version bump and related changes.
locale/en/LC_MESSAGES/pgrouting_doc_strings.po (1)
8058-8060: 4.1.0 upgrade text and empty release-notes stub need content alignmentThe upgrade text explicitly references “version 4.1.0”, but the new “pgRouting 4.1 / pgRouting 4.1.0 Release Notes” section currently just says “No changes yet”. Given this PR already introduces 4.1-specific changes elsewhere, leaving the 4.1.0 notes empty is misleading.
Consider either:
- Drafting at least a brief bullet list of major 4.1.0 changes before release, or
- Hiding the 4.1.0 section until actual notes are available.
Also applies to: 16146-16160
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (42)
.github/workflows/boost_version.yml.github/workflows/centos.yml.github/workflows/check-files.yml.github/workflows/check-queries.yml.github/workflows/clang.yml.github/workflows/doc-check.yml.github/workflows/macos.yml.github/workflows/release.yml.github/workflows/ubuntu.yml.github/workflows/update-locale.yml.github/workflows/update.yml.github/workflows/website.ymlCMakeLists.txtNEWS.mddoc/_static/page_history.jsdoc/src/pgRouting-concepts.rstdoc/src/pgRouting-introduction.rstdoc/src/release_notes.rstdocqueries/version/full_version.resultdocqueries/version/version.resultlocale/de/LC_MESSAGES/index.polocale/de/LC_MESSAGES/pgrouting_doc_strings.polocale/en/LC_MESSAGES/index.polocale/en/LC_MESSAGES/pgrouting_doc_strings.polocale/es/LC_MESSAGES/index.polocale/es/LC_MESSAGES/pgrouting_doc_strings.polocale/ja/LC_MESSAGES/index.polocale/ja/LC_MESSAGES/pgrouting_doc_strings.polocale/ko/LC_MESSAGES/index.polocale/ko/LC_MESSAGES/pgrouting_doc_strings.polocale/pot/index.potlocale/pot/pgrouting_doc_strings.potlocale/sv/LC_MESSAGES/index.polocale/sv/LC_MESSAGES/pgrouting_doc_strings.polocale/zh_Hans/LC_MESSAGES/index.polocale/zh_Hans/LC_MESSAGES/pgrouting_doc_strings.posql/coloring/sequentialVertexColoring.sqlsql/scripts/build-extension-update-files.plsql/sigs/pgrouting--4.1.sigtools/developer/pumpup_version.shtools/developer/run.shtools/testers/pg_prove_tests.sh
🔇 Additional comments (43)
sql/coloring/sequentialVertexColoring.sql (1)
30-30: LGTM! Version annotation standardization.The change standardizes the version marker format to
--v3.2, aligning with the repository's version annotation conventions.doc/_static/page_history.js (1)
8-8: LGTM! Documentation version navigation updated.Correctly adds 4.1 to the supported versions array for documentation version switching. The descending order (4.1, 4.0) is appropriate.
docqueries/version/version.result (1)
9-9: LGTM! Test expectation updated for 4.1.0-dev.The expected version output correctly reflects the 4.1.0-dev version, consistent with the CMakeLists.txt PROJECT_VERSION_DEV setting.
tools/developer/run.sh (1)
62-63: LGTM! Test processing re-enabled.Commenting out the empty assignments restores the active directory specifications (lines 58-59), allowing documentation queries and tap tests to run for the dijkstra subdirectory.
sql/scripts/build-extension-update-files.pl (2)
71-71: LGTM! Version 4.1 regex pattern added.The new version pattern
$version_4_1 = qr/(4.1.[\d+])/;follows the established format and will correctly match 4.1.x versions.
81-81: LGTM! Current version pointer updated.Correctly updates the current version reference to 4.1, consistent with the pgRouting 4.1.0 release.
CMakeLists.txt (4)
33-33: LGTM! Project version bumped to 4.1.0.The version declaration correctly updates pgRouting to 4.1.0, consistent with the release objectives.
35-35: LGTM! Development suffix added.Setting
PROJECT_VERSION_DEVto "-dev" appropriately marks this as a development version, consistent with the test expectation showing "4.1.0-dev" in docqueries/version/version.result.
49-49: LGTM! MINORS list updated for 4.1.Correctly adds 4.1 at the head of the MINORS list, maintaining descending version order for extension upgrade path generation.
51-51: LGTM! Previous version 4.0.0 added to OLD_SIGNATURES.Appropriately adds 4.0.0 to the list of older versions requiring upgrade support, as 4.1 becomes the current version.
locale/pot/pgrouting_doc_strings.pot (4)
2-2: Version header and POT metadata correctly bumped to v4.1The copyright header,
Project-Id-Version, andPOT-Creation-Dateare consistent with a 4.1 cycle; nothing else to adjust here.Also applies to: 9-11
3523-3525: New “pgRouting 4.0” release heading aligns with existing structureAdding the
pgRouting 4.0msgid under the release notes section matches the pattern used for other major versions and looks correct.
6913-6915: Upgrade text updated to 4.1.0The new sentence referring to upgrading “to version 4.1.0” is consistent with the new release versioning; assuming the surrounding SQL snippet was also updated, this looks good.
Please double‑check that the actual
ALTER EXTENSION ... UPDATE TO '4.1.0'(or equivalent) snippet in the .rst sources was updated in sync with this msgid.
13493-13505: 4.1.0 release notes stub is fine, but placeholder should be revisitedThe new 4.1 / 4.1.0 release section and milestone link are consistent with earlier releases. Just ensure the
"No changes yet"line is replaced with real content (or removed) before tagging the final 4.1.0 release so translators don’t ship a permanent placeholder.locale/de/LC_MESSAGES/index.po (1)
2-2: LGTM! Version update aligns with 4.1 release.The version references have been correctly updated from v3.8 to v4.1, consistent with the release cycle.
Also applies to: 8-8
locale/zh_Hans/LC_MESSAGES/index.po (1)
2-2: LGTM! Version update aligns with 4.1 release.The version references have been correctly updated from v3.8 to v4.1.
Also applies to: 8-8
doc/src/pgRouting-concepts.rst (1)
1863-1863: LGTM! Documentation style improvement.The capitalization change from "See also" to "See Also" standardizes the heading format.
sql/sigs/pgrouting--4.1.sig (1)
1-330: The signature file is complete and correctly formatted. It contains 330 function signatures representing 166 unique functions: 91 signatures for 74 internal functions (properly prefixed with_pgr_) and 239 signatures for 92 public functions (usingpgr_prefix). All major algorithm categories are well-represented with appropriate overloads. The structure matches version 4.0 consistently, indicating stable API versioning.locale/sv/LC_MESSAGES/index.po (1)
2-2: LGTM: Version metadata updated correctly.The copyright and Project-Id-Version fields have been updated consistently to reflect pgRouting v4.1.
Also applies to: 8-8
docqueries/version/full_version.result (1)
8-9: LGTM: Test result updated for version 4.1.0-dev.The version result correctly reflects the new 4.1.0-dev version with updated library name and proper formatting.
locale/ja/LC_MESSAGES/index.po (1)
2-2: LGTM: Version metadata updated correctly.The copyright and Project-Id-Version fields have been updated consistently to reflect pgRouting v4.1.
Also applies to: 8-8
tools/developer/pumpup_version.sh (1)
127-127: LGTM: Path corrected to target the actual result file.The script now correctly updates
full_version.resultinstead of the non-existentdoc-full_version.result, aligning with the actual file location atdocqueries/version/full_version.result.locale/es/LC_MESSAGES/index.po (1)
2-2: LGTM: Version metadata updated correctly.The copyright and Project-Id-Version fields have been updated consistently to reflect pgRouting v4.1.
Also applies to: 8-8
.github/workflows/centos.yml (1)
35-35: Verify actions/checkout@v6 compatibility.The checkout action has been upgraded from v5 to v6, which is a major version change. Ensure compatibility with your self-hosted runner environment and verify that no breaking changes affect this workflow.
.github/workflows/website.yml (1)
31-31: No breaking change impact for this workflow — credentials are handled via GITHUB_TOKEN.The actions/checkout v6 migration includes breaking changes around credential storage (.git/config → $RUNNER_TEMP), but this workflow mitigates the primary concern by explicitly passing credentials through the
GITHUB_TOKENenvironment variable rather than relying on .git/config. The explicit git user configuration (lines 89-91) andcontents: writepermission are already in place. Verify that the workflow executes successfully in practice to confirm v6 compatibility.locale/ko/LC_MESSAGES/index.po (1)
2-8: LGTM! Version metadata correctly updated.The copyright and Project-Id-Version headers are appropriately updated to reflect pgRouting v4.1.
tools/testers/pg_prove_tests.sh (1)
40-40: LGTM! Test database version updated correctly.The setup_db.sh invocation now uses version 4.1.0, aligning with the project version bump.
locale/en/LC_MESSAGES/index.po (1)
2-9: LGTM! Version metadata correctly updated.The copyright and Project-Id-Version headers are appropriately updated to reflect pgRouting v4.1.
locale/pot/index.pot (1)
2-9: LGTM! Version metadata correctly updated.The copyright and Project-Id-Version headers are appropriately updated to reflect pgRouting v4.1.
.github/workflows/check-queries.yml (1)
58-58: Verify credential storage and runner compatibility for actions/checkout@v6.This upgrade introduces breaking changes:
persist-credentialsnow writes to$RUNNER_TEMPinstead of.git/config— if scripts or tools in this workflow rely on credentials in.git/config, they will fail.- Docker container actions require Actions Runner >= v2.329.0 — self-hosted Docker runners must be upgraded.
Review the workflow to confirm it doesn't depend on credentials in
.git/configand that any self-hosted runners meet the version requirement..github/workflows/macos.yml (1)
51-51: No action needed. The upgrade to actions/checkout@v6 is safe for this workflow.The breaking changes in v6 do not apply here: this workflow does not use Docker container actions (no runner version requirement concern) and does not access credentials from .git/config. Standard git operations like the
git cloneused in the "Install pgTAP" step continue to work without modification..github/workflows/check-files.yml (1)
23-67: No breaking changes affect these workflows. All git operations in the called scripts (git ls-files,git rev-parse,git status) are read-only and don't require authentication. The two main breaking changes in checkout v6—credentials storage redirection and Docker-container runner requirements—don't apply here since the workflow usesubuntu-latestand performs no authenticated git operations..github/workflows/ubuntu.yml (1)
43-43: actions/checkout@v6 is compatible with this workflow — no changes required.The main breaking change in v6 (credentials persisted to a separate file instead of .git/config) is transparent for standard workflows like this one. This workflow runs on standard GitHub runners, uses no Docker container actions, and has no custom authentication setup, so it will continue to work without modification.
.github/workflows/boost_version.yml (2)
132-132: LGTM! Test database version updated correctly.The test database setup version has been updated from 4.0.0 to 4.1.0, which is consistent with the release cycle.
74-74: actions/checkout@v6 is stable and compatible with this workflow.The upgrade from v5 to v6 introduces one significant change: credentials persistence now uses a separate file under $RUNNER_TEMP instead of directly modifying .git/config. This is a security improvement and is transparent to most workflows—git fetch and git push continue to work without modification. Only custom platforms or workflows that directly read .git/config may need adjustments. For Docker container actions, Actions Runner v2.329.0+ is required. This upgrade is safe for standard CI workflows.
doc/src/release_notes.rst (1)
48-54: LGTM! pgRouting 4.0 section properly preserved.The previous release section has been correctly restructured to maintain the release history.
doc/src/pgRouting-introduction.rst (1)
114-114: LGTM! Contributor name added correctly.The contributor name has been added in the correct alphabetical position.
.github/workflows/update.yml (3)
51-51: LGTM! Added 4.0.0 to upgrade test matrix.Adding 4.0.0 to the old_pgr matrix ensures that upgrade paths from the previous major version are tested.
148-148: LGTM! Extension update version correctly updated.The ALTER EXTENSION command now updates to version 4.1.0, which is consistent with the release cycle.
54-54: actions/checkout@v6 is available and backwards compatible.Version 6 is officially released and stable. It maintains backwards compatibility with v5 for typical workflows—normal git operations (fetch, push, etc.) work unchanged. The main change is credentials handling: they're now written to a separate file under $RUNNER_TEMP instead of directly to .git/config.
Consider this if your workflow runs authenticated git commands from a Docker container action: GitHub Actions Runner v2.329.0 or later is required. Also note: workflows that directly read .git/config, use custom credential handling, or have unusual GHES setups may need adjustments.
locale/en/LC_MESSAGES/pgrouting_doc_strings.po (3)
2-11: Header metadata bump to v4.1 looks consistentProject-Id-Version and POT-Creation-Date correctly reflect pgRouting v4.1 and a new extraction timestamp; nothing problematic here.
68-248: Bulk msgstr fills for code literals / column names are consistentAcross these ranges, msgstr values now mirror the msgid for data types, column identifiers, and Sphinx refs (e.g.,
TEXT,BIGINT,max_depth,pid,edge_id,reverse_capacity, coordinate columns, and result-column names). This keeps English docs explicit and consistent and should not affect behavior.Also applies to: 788-915, 927-1045, 1077-1222, 3335-3336, 3569-3606, 7719-7739, 7837-7843
8389-8402: Contributors list update (adds “Aadi Pandey” etc.) remains coherentThe consolidated contributors string now includes “Aadi Pandey” and other names while preserving alphabetical ordering as claimed in the surrounding text. Spelling and formatting (commas, spacing) look consistent with the rest of the list.
|
|
||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - uses: actions/checkout@v6 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
actions/checkout v6 breaking changes migration guide official
💡 Result:
Summary — key breaking-change notes and migration steps for actions/checkout v6
What changed
- persist-credentials now writes credentials to a separate file under $RUNNER_TEMP (not directly to .git/config). This improves security. [1][2]
- For most workflows nothing must change: normal git commands (git fetch, git push, etc.) continue to work because the action configures includeIf entries so Git will use the persisted credentials file. [1][3]
- Running authenticated git commands from inside a Docker container action requires GitHub Actions Runner v2.329.0 or later. [1][2]
Migration checklist (very short)
- Update the step to use v6:
- uses: actions/checkout@v6. [1]
- If your workflows run authenticated git commands inside Docker container actions, ensure the self-hosted or GitHub-hosted runner version is >= v2.329.0. If not, upgrade the runner. [1][2]
- If you rely on custom SSH setups, nonstandard git credential tooling, or GitHub Enterprise Server deployments, test those workflows — v6’s credential file location may require adjusting how you reference keys/config. (See repo/issue discussion for edge cases.) [3]
- Optional: review the v6 README/changelog for details and worktree/includeIf updates. [1][4]
References
- actions/checkout README (v6 notes). [1]
- GitHub Marketplace Checkout v6 summary. [2]
- Issue discussion clarifying behavior and includeIf rationale. [3]
- v6 release/patch notes (v6.0.1). [4]
Review actions/checkout@v6 breaking changes for credential persistence.
v6 is a semver-major update with breaking changes around credential handling. The key change: credentials now persist to a separate file under $RUNNER_TEMP instead of directly in .git/config. For most workflows, git commands continue working. However, if this workflow uses Docker container actions with authenticated git commands, ensure the runner version is >= v2.329.0. If using custom SSH setups, nonstandard credential tooling, or GitHub Enterprise Server, test the workflow to verify compatibility with the new credential file location.
🤖 Prompt for AI Agents
In .github/workflows/doc-check.yml around line 56, the workflow upgrades
actions/checkout to v6 which changes credential persistence (credentials are
written to a file under $RUNNER_TEMP instead of .git/config) and may break
Docker/container steps or custom SSH tooling; either pin back to
actions/checkout@v5 if you don't want to change behavior, or keep v6 but update
the workflow to ensure runner >= v2.329.0 and adjust any steps that rely on
credentials in .git/config (e.g., mount or expose the $RUNNER_TEMP credentials
file into containers, update custom SSH/credential tooling to read from the new
file location, and add validation steps/tests to confirm authenticated git
commands work in your Docker/enterprise environment).
| pgRouting 4.1 | ||
| +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ | ||
|
|
||
| .. contents:: Contents | ||
| :local: | ||
| :depth: 1 | ||
|
|
||
|
|
||
| pgRouting 4.1.0 Release Notes | ||
| ------------------------------------------------------------------------------- | ||
|
|
||
| To see all issues & pull requests closed by this release see the | ||
| :milestone:`4.1.0` | ||
|
|
||
| No changes yet | ||
|
|
There was a problem hiding this comment.
Complete the release notes before finalizing the release.
The new pgRouting 4.1.0 section contains only "No changes yet" as a placeholder. Release notes should document all changes, new features, bug fixes, breaking changes, and migration guidance before the release is finalized.
Please populate this section with:
- Summary of changes
- New features
- Bug fixes
- Breaking changes (if any)
- Migration guidance
- Deprecated features
🤖 Prompt for AI Agents
In doc/src/release_notes.rst around lines 30 to 45, the pgRouting 4.1.0 section
currently contains only the placeholder "No changes yet"; replace that
placeholder with a complete release-notes entry that includes a concise Summary
of changes, a "New features" subsection listing added functionality, a "Bug
fixes" subsection enumerating resolved issues (with short issue/PR references),
a "Breaking changes" subsection (or "None" if none), a "Migration guidance"
subsection with upgrade steps or SQL/API changes users must apply, and a
"Deprecated features" subsection listing deprecations and timelines; ensure each
subsection uses the same rst heading style as the file and keep entries short,
referenceable, and linked to issues/PRs where applicable.
| msgid "Aadi Pandey, Aasheesh Tiwari, Abhinav Jain, Aditya Pratap Singh, Adrien Berchet, Akio Takubo, Andrea Nardelli, Anthony Tasca, Anton Patrushev, Aryan Gupta, Ashraf Hossain, Ashish Kumar, Aurélie Bousquet, Bipasha Gayary, Cayetano Benavent, Christian Gonzalez, Daniel Kastl, Dapeng Wang, Dave Potts, David Techer, Denis Rykov, Ema Miyawaki, Esteban Zimanyi, Fan Wu, Florian Thurkow, Frederic Junod, Gerald Fenoy, Gudesa Venkata Sai Akhil, Hang Wu, Himanshu Raj, Imre Samu, Jay Mahadeokar, Jinfu Leng, Kai Behncke, Kishore Kumar, Ko Nagase, Mahmoud Sakr, Manikata Kondeti, Mario Basa, Martin Wiesenhaan, Maxim Dubinin, Maoguang Wang, Mohamed Bakli, Mohamed Zia, Mukul Priya, Nitish Chauhan, Rajat Shinde, Razequl Islam, Regina Obe, Rohith Reddy, Saloni Kumari, Sarthak Agarwal, Shobhit Chaurasia, Sourabh Garg, Stephen Woodbridge, Swapnil Joshi, Sylvain Housseman, Sylvain Pasche, Veenit Kumar, Vidhan Jain, Virginia Vergara, Yige Huang" | ||
| msgstr "" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Check the file size first
wc -l locale/pot/pgrouting_doc_strings.potRepository: pgRouting/GSoC-pgRouting
Length of output: 110
🏁 Script executed:
# Look at line 7168 to see what's actually there
sed -n '7165,7170p' locale/pot/pgrouting_doc_strings.potRepository: pgRouting/GSoC-pgRouting
Length of output: 128
🏁 Script executed:
# Look at lines 7204-7205 to see the full context
sed -n '7200,7210p' locale/pot/pgrouting_doc_strings.potRepository: pgRouting/GSoC-pgRouting
Length of output: 1157
🏁 Script executed:
# Search for all occurrences of Vergara in the file
rg 'Vergara' locale/pot/pgrouting_doc_strings.potRepository: pgRouting/GSoC-pgRouting
Length of output: 1104
Standardize contributor name to match file usage
The file lists "Vicky Vergara" in the translator section (line 7168) and in the Russian translators list, but uses "Virginia Vergara" in the "Individuals (in alphabetical order)" section (lines 7204-7205). Change "Virginia Vergara" to "Vicky Vergara" to maintain consistency.
🤖 Prompt for AI Agents
In locale/pot/pgrouting_doc_strings.pot around lines 7204-7205, the contributor
name "Virginia Vergara" in the Individuals list is inconsistent with "Vicky
Vergara" used elsewhere; update the string by replacing "Virginia Vergara" with
"Vicky Vergara" so the contributor name is consistent across the file.
4 participants
Fixes # .
Changes proposed in this pull request:
@pgRouting/admins
Summary by CodeRabbit
Release Notes
New Features
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.