Version bump: 4.0.0 → 4.1.0-dev and add Kunal Chandola to contributors #517
Conversation
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…elop/actions/checkout-6 Bump actions/checkout from 5 to 6
pumpup to 4.1.0 dev
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Co-authored-by: Weblate <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/ Translation: pgRouting/pgRouting
…g-develop Translations update from OSGeo Weblate
Currently translated at 100.0% (5383 of 5383 strings) Co-authored-by: Daniel Nylander <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/sv/ Translation: pgRouting/pgRouting
Currently translated at 86.2% (4644 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.2% (4643 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.2% (4641 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4640 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4637 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4636 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4635 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4634 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4633 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4632 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4631 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4630 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4629 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4628 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4627 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4626 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4625 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4624 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4623 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4622 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4621 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4620 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4619 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4618 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4617 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4616 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4615 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4614 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4613 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4612 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4611 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4610 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4609 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4608 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4607 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4605 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4604 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4603 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4602 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4601 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4600 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4599 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4598 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4597 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4596 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4595 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4594 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4593 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.2% (4590 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.2% (4589 of 5383 strings) Co-authored-by: DeepL <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/ Translation: pgRouting/pgRouting
Currently translated at 86.3% (4646 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.2% (4643 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4640 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4635 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4634 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4633 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4632 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4627 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4626 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4622 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4617 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4616 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4613 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4610 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4607 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4605 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4603 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4601 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4600 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4598 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4597 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4595 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4594 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4593 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.2% (4590 of 5383 strings) Co-authored-by: Celia Virginia Vergara Castillo <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/ Translation: pgRouting/pgRouting
Currently translated at 86.3% (4646 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.3% (4650 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.3% (4650 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4651 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4652 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4653 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4653 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4654 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4654 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4655 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4655 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4656 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4656 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.5% (4658 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.5% (4658 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4663 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4663 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4664 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4664 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4665 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4666 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4666 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4667 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.7% (4672 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.7% (4672 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4673 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4674 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4674 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4674 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4675 of 5383 strings) Co-authored-by: Celia Virginia Vergara Castillo <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/ Translation: pgRouting/pgRouting
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Co-authored-by: Weblate <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/ Translation: pgRouting/pgRouting
Currently translated at 87.3% (4700 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 87.3% (4700 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 87.3% (4701 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 87.5% (4714 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 87.5% (4714 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
WalkthroughBumps project version to 4.1.0, adds a new pgrouting extension signature file for 4.1, updates CI checkout actions to actions/checkout@v6, adjusts build/test scripts and expected version outputs, and refreshes docs and localization metadata. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tools/developer/run.sh (1)
58-63: Remove the developer-specific dijkstra configuration or restore the default settings.This file is a template (header states "Copy this file into the root of your repository" and "Adjust to your developing needs"). The committed version has the dijkstra-specific configuration active (lines 58-59), which limits processing to a single subdirectory. Either comment out these lines and restore the defaults (lines 54-55 which process all subdirectories), or remove the dijkstra customization entirely from the committed version.
🧹 Nitpick comments (5)
doc/src/pgRouting-concepts.rst (1)
1863-1863: Minor capitalization refinement.The heading has been updated to title case for consistency. This is a minor documentation polish.
locale/pot/pgrouting_doc_strings.pot (3)
3523-3525: Confirm intent of “pgRouting 4.0” major headingThis msgid still reads “pgRouting 4.0” while new 4.1-specific entries are added later in the file. That’s fine if this section is explicitly the 4.0 major release notes; if you instead want a generic major “pgRouting 4” heading, this is the place to adjust.
13495-13505: New 4.1.0 release‑notes strings are well‑formed placeholdersThe added “pgRouting 4.1”, “pgRouting 4.1.0 Release Notes”, milestone link, and “No changes yet” stub follow the existing 3.x/4.0 pattern and give translators the right hooks. Just remember to replace the “No changes yet” text once actual 4.1.0 content is finalized.
7204-7205: Contributor list update and minor naming consistency nitAdding “Kunal Chandola” into the alphabetical individuals list is correct and preserves ordering. While touching this string, consider aligning “Virginia Vergara” with the “Vicky Vergara” spelling used elsewhere in the file if they are meant to refer to the same person.
locale/en/LC_MESSAGES/pgrouting_doc_strings.po (1)
8058-8060: 4.1.0 upgrade and release-notes stubs look correct but are placeholdersThe new upgrade note (“upgrade pgRouting in the database to version 4.1.0”) and the
pgRouting 4.1/pgRouting 4.1.0 Release Notesblock, including the “No changes yet” msgid, are structurally consistent with prior 3.x/4.0 sections. Once 4.1.0 is finalized you’ll likely want to replace “No changes yet” with actual change bullets.Also applies to: 16147-16160
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (42)
.github/workflows/boost_version.yml.github/workflows/centos.yml.github/workflows/check-files.yml.github/workflows/check-queries.yml.github/workflows/clang.yml.github/workflows/doc-check.yml.github/workflows/macos.yml.github/workflows/release.yml.github/workflows/ubuntu.yml.github/workflows/update-locale.yml.github/workflows/update.yml.github/workflows/website.ymlCMakeLists.txtNEWS.mddoc/_static/page_history.jsdoc/src/pgRouting-concepts.rstdoc/src/pgRouting-introduction.rstdoc/src/release_notes.rstdocqueries/version/full_version.resultdocqueries/version/version.resultlocale/de/LC_MESSAGES/index.polocale/de/LC_MESSAGES/pgrouting_doc_strings.polocale/en/LC_MESSAGES/index.polocale/en/LC_MESSAGES/pgrouting_doc_strings.polocale/es/LC_MESSAGES/index.polocale/es/LC_MESSAGES/pgrouting_doc_strings.polocale/ja/LC_MESSAGES/index.polocale/ja/LC_MESSAGES/pgrouting_doc_strings.polocale/ko/LC_MESSAGES/index.polocale/ko/LC_MESSAGES/pgrouting_doc_strings.polocale/pot/index.potlocale/pot/pgrouting_doc_strings.potlocale/sv/LC_MESSAGES/index.polocale/sv/LC_MESSAGES/pgrouting_doc_strings.polocale/zh_Hans/LC_MESSAGES/index.polocale/zh_Hans/LC_MESSAGES/pgrouting_doc_strings.posql/coloring/sequentialVertexColoring.sqlsql/scripts/build-extension-update-files.plsql/sigs/pgrouting--4.1.sigtools/developer/pumpup_version.shtools/developer/run.shtools/testers/pg_prove_tests.sh
🔇 Additional comments (42)
.github/workflows/doc-check.yml (1)
56-56: LGTM!Consistent with the checkout action upgrade across other workflow files.
.github/workflows/check-queries.yml (1)
58-58: LGTM!Consistent with the checkout action upgrade across other workflow files.
docqueries/version/version.result (1)
9-9: LGTM!Version change from 4.0.0 to 4.1.0-dev correctly reflects the project version bump mentioned in the AI summary.
.github/workflows/clang.yml (1)
58-58: LGTM!Consistent with the checkout action upgrade across other workflow files.
.github/workflows/website.yml (1)
31-31: LGTM!Consistent with the checkout action upgrade across other workflow files.
.github/workflows/ubuntu.yml (1)
43-43: LGTM!Consistent with the checkout action upgrade across other workflow files.
.github/workflows/release.yml (1)
21-21: LGTM!Consistent with the checkout action upgrade across other workflow files.
.github/workflows/macos.yml (1)
51-51: No action required — actions/checkout@v6 is non-breaking for typical workflows.The upgrade from v5 to v6 introduces only credential storage improvements (persisted in a separate file for better security), with no breaking changes for standard workflows. Ordinary git fetch/push behavior remains unchanged. Only Docker container actions require runner v2.329.0 or later for authenticated git commands, but this is a documented conditional requirement, not a breaking change.
locale/sv/LC_MESSAGES/index.po (1)
2-8: LGTM!The version metadata update from v3.8 to v4.1 is consistent with the project-wide version bump.
locale/pot/index.pot (1)
2-9: LGTM!Version metadata correctly updated to v4.1, consistent with other locale files and the project version bump.
sql/scripts/build-extension-update-files.pl (2)
71-71: LGTM!The new version regex follows the established pattern used by all previous version definitions.
81-81: LGTM!Correctly sets the current version to 4.1, enabling the build script to generate upgrade files for the new release.
.github/workflows/boost_version.yml (2)
74-74: LGTM!Checkout action upgrade to v6 is consistent with other workflow files in this PR.
132-132: LGTM!Test setup correctly updated to use version 4.1.0, aligning with the project version bump.
sql/coloring/sequentialVertexColoring.sql (1)
30-30: Good fix!The version annotation format is corrected from
---3.2to--v3.2. This matches the regex pattern--v([\d+].[\d+])used inbuild-extension-update-files.pl(line 392) for version-based upgrade script generation.locale/ja/LC_MESSAGES/index.po (1)
2-8: LGTM!Version metadata correctly updated to v4.1, consistent with the project-wide version bump.
locale/de/LC_MESSAGES/index.po (1)
2-8: LGTM!Version metadata correctly updated to v4.1, consistent with other locale files in this PR.
.github/workflows/centos.yml (1)
35-35: Good upgrade. actions/checkout v6 is officially released (November 20, 2025) and stable. The version bump aligns with CI modernization. Note that v6 persists credentials to a separate file under $RUNNER_TEMP for improved security, and requires runner v2.329.0+ if running authenticated git commands from Docker containers.locale/es/LC_MESSAGES/index.po (1)
2-8: LGTM! Version metadata correctly updated.The Spanish locale file metadata has been properly updated to reflect the pgRouting v4.1 version bump.
locale/ko/LC_MESSAGES/index.po (1)
2-8: LGTM! Version metadata correctly updated.The Korean locale file metadata has been properly updated to reflect the pgRouting v4.1 version bump.
tools/testers/pg_prove_tests.sh (1)
40-40: LGTM! Test setup version updated correctly.The version parameter has been properly updated to 4.1.0, aligning with the project-wide version bump.
.github/workflows/update.yml (3)
51-51: LGTM! Matrix extended to include 4.0.0.Adding 4.0.0 to the old_pgr matrix is appropriate for testing upgrade paths from the previous version to 4.1.0.
148-148: LGTM! Extension version updated correctly.The PostgreSQL extension update command now references version 4.1.0, consistent with the project-wide version bump.
54-54: actions/checkout@v6 is compatible with this workflow.The upgrade from v5 to v6 does not introduce breaking changes for standard repository checkout operations. The primary change is credential handling (auth written to a separate file rather than .git/config), but git commands continue to work automatically without workflow modifications. No action needed.
doc/_static/page_history.js (1)
8-8: LGTM! Version 4.1 added to documentation history.The versionsArr has been correctly updated to include version 4.1, enabling proper version navigation in the documentation.
.github/workflows/update-locale.yml (1)
33-33: Verify actions/checkout@v6 compatibility.The checkout action has been upgraded from v5 to v6. Ensure this version is compatible with your workflow requirements. This is the same upgrade applied in update.yml.
The verification query for this change is the same as in
.github/workflows/update.yml.doc/src/pgRouting-introduction.rst (1)
149-149: LGTM! Contributor added correctly.The contributor "Kunal Chandola" has been added in the correct alphabetical position with proper formatting.
locale/en/LC_MESSAGES/index.po (1)
2-2: Localization metadata updated for version 4.1.The version references in the English localization file have been updated from v3.8 to v4.1. This is part of the broader version bump that should be documented in the PR description.
Also applies to: 9-9
locale/zh_Hans/LC_MESSAGES/index.po (1)
2-2: Localization metadata updated consistently.The Chinese (Simplified) localization file has been updated with the same version changes as the English locale file (v3.8 → v4.1), maintaining consistency across translations.
Also applies to: 8-8
NEWS.md (1)
6-16: Release notes scaffolding added for pgRouting 4.1.A new section has been added for pgRouting 4.1.0 with a "No changes yet" placeholder. This indicates that the actual release notes should be populated before the 4.1.0 release.
doc/src/release_notes.rst (1)
30-45: Release notes scaffolding matches NEWS.md.The release notes structure for pgRouting 4.1.0 has been added consistently with the NEWS.md file, including the same "No changes yet" placeholder.
tools/developer/pumpup_version.sh (1)
127-127: Bug fix is valid. The corrected filenamedocqueries/version/full_version.resultexists in the repository, whiledocqueries/version/doc-full_version.resultdoes not exist anywhere in the codebase. This change fixes a bug in the script where the wrong filename was being targeted during minor version pump-up..github/workflows/check-files.yml (1)
23-23: actions/checkout@v6 is stable and safe for this workflow.The upgrade from v5 to v6 is safe for standard workflows. The main change is credential handling (persist-credentials now writes to a separate file instead of .git/config), which is a security improvement that doesn't break typical git operations. No workflow modifications are needed unless you run authenticated git commands from within Docker container actions, which would require Actions Runner v2.329.0 or later.
Also applies to: 32-32, 43-43, 54-54, 65-67
docqueries/version/full_version.result (1)
8-9: Version bump test result looks correct.The test result correctly reflects the version bump to 4.1.0-dev and pgrouting-4.1.0. The format is consistent with PostgreSQL test output expectations.
However, note that the PR title "Added Kunal Chandola to Contributors List" does not match these version bump changes. No contributor list modifications are present in the files under review.
CMakeLists.txt (4)
49-49: MINORS list correctly updated with 4.1.The new minor version 4.1 is properly prepended to the list while preserving the existing version history.
33-51: PR title does not match the actual changes.The PR is titled "Added Kunal Chandola to Contributors List" but the files under review only contain version bump changes from 4.0.0 to 4.1.0. No contributor list modifications are present in these files.
Please verify:
- Are contributor list changes in other files not included in this review?
- Should the PR title be updated to reflect the version bump?
- Or should these version changes be in a separate PR?
33-35: Version bump from 4.0.0 to 4.1.0-dev is correct and complete.The project version declaration in CMakeLists.txt (lines 33-35) properly updates to version 4.1.0 with the dev suffix. Verification confirms all remaining 4.0.0 references in the codebase are in appropriate contexts: the OLD_SIGNATURES list for backwards compatibility tracking, version conditionals in test files (min_version checks), and version markers in SQL source files indicating when functions were introduced. No stray references indicate incomplete version updates.
51-51: OLD_SIGNATURES correctly updated with 4.0.0.Adding 4.0.0 to the OLD_SIGNATURES list is the correct approach for maintaining upgrade paths from the previous version. The required signature file
pgrouting--4.0.sigexists insql/sigs/, and the build system is properly configured to generate upgrade scripts (pgrouting--4.0.0--4.1.0.sql) with the correct dependencies.locale/pot/pgrouting_doc_strings.pot (1)
2-11: Header metadata bump to 4.1 looks consistent
Project-Id-Version, copyright comment, andPOT-Creation-Dateare all aligned to v4.1 and the current generation time; this matches the intended 4.1 doc refresh.locale/en/LC_MESSAGES/pgrouting_doc_strings.po (3)
2-12: Version header and POT metadata are consistent with v4.1
Project-Id-Version, copyright header, and POT creation date are aligned to a 4.1.0 cycle and look internally consistent; nothing to change here.
68-79: Bulk msgstr additions for code-like tokens and references are fineThe many new
msgstrentries that exactly mirror code-stylemsgidvalues (types, column names, Sphinx refs, etc.) are mechanically correct for theenlocale and don’t introduce semantic changes. No action needed.Also applies to: 124-147, 154-177, 204-221, 225-248, 240-242, 279-284, 787-804, 811-813, 852-854, 862-869, 883-890, 905-907, 913-915, 926-934, 938-946, 959-961, 1004-1004, 1018-1020, 1037-1039, 1043-1045, 1077-1078, 1088-1090, 1100-1102, 1116-1118, 1135-1137, 1156-1158, 1167-1168, 1175-1177, 1188-1189, 1199-1201, 1208-1210, 1220-1222, 1303-1307, 1371-1373, 1449-1453, 1510-1511, 1551-1551, 1563-1565, 1580-1580, 1603-1605, 1662-1663, 1685-1687, 1691-1693, 1765-1767, 1815-1822, 1961-1963, 2004-2005, 2087-2091, 2199-2200, 2298-2299, 2364-2365, 2445-2449, 2463-2467, 2479-2485, 2499-2503, 2601-2603, 2689-2692, 2963-2965, 2984-2986, 2991-2992, 2999-3006, 3047-3047, 3200-3204, 3241-3244, 3279-3283, 3334-3336, 3401-3404, 3481-3486, 3568-3570, 3604-3606, 3712-3712, 3733-3735, 3809-3811, 3963-3973, 4001-4001, 4300-4304, 4434-4466, 4495-4497, 4521-4522, 4565-4567, 4597-4599, 4606-4608, 4622-4624, 4676-4678, 4701-4703, 4754-4756, 4783-4785, 4803-4806, 4843-4846, 4864-4866, 4927-4931, 4967-4975, 6009-6015
8385-8402: “Kunal Chandola” correctly added to contributors listThe contributors
msgidnow includes “Kunal Chandola” and keeps the list alphabetized by first name (Kai,Kishore,Ko,Kunal,Mahmoud). This matches the existing ordering convention; no further changes needed.
| _pgr_array_reverse(anyarray) | ||
| _pgr_articulationpoints(text) | ||
| pgr_articulationpoints(text) | ||
| pgr_astarcostmatrix(text,anyarray,boolean,integer,double precision,double precision) | ||
| pgr_astarcost(text,anyarray,anyarray,boolean,integer,double precision,double precision) | ||
| pgr_astarcost(text,anyarray,bigint,boolean,integer,double precision,double precision) | ||
| pgr_astarcost(text,bigint,anyarray,boolean,integer,double precision,double precision) | ||
| pgr_astarcost(text,bigint,bigint,boolean,integer,double precision,double precision) | ||
| pgr_astarcost(text,text,boolean,integer,double precision,double precision) | ||
| pgr_astar(text,anyarray,anyarray,boolean,integer,double precision,double precision) | ||
| _pgr_astar(text,anyarray,anyarray,boolean,integer,double precision,double precision,boolean,boolean) | ||
| pgr_astar(text,anyarray,bigint,boolean,integer,double precision,double precision) | ||
| pgr_astar(text,bigint,anyarray,boolean,integer,double precision,double precision) | ||
| pgr_astar(text,bigint,bigint,boolean,integer,double precision,double precision) | ||
| pgr_astar(text,text,boolean,integer,double precision,double precision) | ||
| _pgr_astar(text,text,boolean,integer,double precision,double precision,boolean) | ||
| _pgr_bandwidth(text) | ||
| pgr_bandwidth(text) | ||
| pgr_bdastarcostmatrix(text,anyarray,boolean,integer,numeric,numeric) | ||
| pgr_bdastarcost(text,anyarray,anyarray,boolean,integer,numeric,numeric) | ||
| pgr_bdastarcost(text,anyarray,bigint,boolean,integer,numeric,numeric) | ||
| pgr_bdastarcost(text,bigint,anyarray,boolean,integer,numeric,numeric) | ||
| pgr_bdastarcost(text,bigint,bigint,boolean,integer,numeric,numeric) | ||
| pgr_bdastarcost(text,text,boolean,integer,numeric,numeric) | ||
| _pgr_bdastar(text,anyarray,anyarray,boolean,integer,double precision,double precision,boolean) | ||
| pgr_bdastar(text,anyarray,anyarray,boolean,integer,numeric,numeric) | ||
| pgr_bdastar(text,anyarray,bigint,boolean,integer,numeric,numeric) | ||
| pgr_bdastar(text,bigint,anyarray,boolean,integer,numeric,numeric) | ||
| pgr_bdastar(text,bigint,bigint,boolean,integer,numeric,numeric) | ||
| _pgr_bdastar(text,text,boolean,integer,double precision,double precision,boolean) | ||
| pgr_bdastar(text,text,boolean,integer,numeric,numeric) | ||
| pgr_bddijkstracostmatrix(text,anyarray,boolean) | ||
| pgr_bddijkstracost(text,anyarray,anyarray,boolean) | ||
| pgr_bddijkstracost(text,anyarray,bigint,boolean) | ||
| pgr_bddijkstracost(text,bigint,anyarray,boolean) | ||
| pgr_bddijkstracost(text,bigint,bigint,boolean) | ||
| pgr_bddijkstracost(text,text,boolean) | ||
| pgr_bddijkstra(text,anyarray,anyarray,boolean) | ||
| _pgr_bddijkstra(text,anyarray,anyarray,boolean,boolean) | ||
| pgr_bddijkstra(text,anyarray,bigint,boolean) | ||
| pgr_bddijkstra(text,bigint,anyarray,boolean) | ||
| pgr_bddijkstra(text,bigint,bigint,boolean) | ||
| pgr_bddijkstra(text,text,boolean) | ||
| _pgr_bddijkstra(text,text,boolean,boolean) | ||
| pgr_bellmanford(text,anyarray,anyarray,boolean) | ||
| _pgr_bellmanford(text,anyarray,anyarray,boolean,boolean) | ||
| pgr_bellmanford(text,anyarray,bigint,boolean) | ||
| pgr_bellmanford(text,bigint,anyarray,boolean) | ||
| pgr_bellmanford(text,bigint,bigint,boolean) | ||
| pgr_bellmanford(text,text,boolean) | ||
| _pgr_bellmanford(text,text,boolean,boolean) | ||
| _pgr_betweennesscentrality(text,boolean) | ||
| pgr_betweennesscentrality(text,boolean) | ||
| _pgr_biconnectedcomponents(text) | ||
| pgr_biconnectedcomponents(text) | ||
| _pgr_binarybreadthfirstsearch(text,anyarray,anyarray,boolean) | ||
| pgr_binarybreadthfirstsearch(text,anyarray,anyarray,boolean) | ||
| pgr_binarybreadthfirstsearch(text,anyarray,bigint,boolean) | ||
| pgr_binarybreadthfirstsearch(text,bigint,anyarray,boolean) | ||
| pgr_binarybreadthfirstsearch(text,bigint,bigint,boolean) | ||
| _pgr_binarybreadthfirstsearch(text,text,boolean) | ||
| pgr_binarybreadthfirstsearch(text,text,boolean) | ||
| _pgr_bipartite(text) | ||
| pgr_bipartite(text) | ||
| _pgr_boost_version() | ||
| pgr_boykovkolmogorov(text,anyarray,anyarray) | ||
| pgr_boykovkolmogorov(text,anyarray,bigint) | ||
| pgr_boykovkolmogorov(text,bigint,anyarray) | ||
| pgr_boykovkolmogorov(text,bigint,bigint) | ||
| pgr_boykovkolmogorov(text,text) | ||
| _pgr_breadthfirstsearch(text,anyarray,bigint,boolean) | ||
| pgr_breadthfirstsearch(text,anyarray,boolean,bigint) | ||
| pgr_breadthfirstsearch(text,bigint,boolean,bigint) | ||
| _pgr_bridges(text) | ||
| pgr_bridges(text) | ||
| _pgr_build_type() | ||
| _pgr_checkcolumn(text,text,text,boolean,boolean) | ||
| _pgr_checkquery(text) | ||
| pgr_chinesepostmancost(text) | ||
| pgr_chinesepostman(text) | ||
| _pgr_chinesepostman(text,boolean) | ||
| _pgr_compilation_date() | ||
| _pgr_compiler_version() | ||
| _pgr_connectedcomponents(text) | ||
| pgr_connectedcomponents(text) | ||
| pgr_contractiondeadend(text,boolean,bigint[]) | ||
| _pgr_contractionhierarchies(text,bigint[],boolean) | ||
| pgr_contractionhierarchies(text,boolean,bigint[]) | ||
| pgr_contractionlinear(text,boolean,bigint[]) | ||
| _pgr_contraction(text,bigint[],integer,bigint[],boolean) | ||
| pgr_contraction(text,boolean,integer[],integer,bigint[]) | ||
| _pgr_cuthillmckeeordering(text) | ||
| pgr_cuthillmckeeordering(text) | ||
| pgr_dagshortestpath(text,anyarray,anyarray) | ||
| pgr_dagshortestpath(text,anyarray,bigint) | ||
| pgr_dagshortestpath(text,bigint,anyarray) | ||
| pgr_dagshortestpath(text,bigint,bigint) | ||
| pgr_dagshortestpath(text,text) | ||
| _pgr_dagshortestpath_v4(text,anyarray,anyarray,boolean,boolean) | ||
| _pgr_dagshortestpath_v4(text,text,boolean) | ||
| pgr_degree(text,boolean) | ||
| pgr_degree(text,text,boolean) | ||
| _pgr_depthfirstsearch(text,anyarray,boolean,bigint) | ||
| pgr_depthfirstsearch(text,anyarray,boolean,bigint) | ||
| pgr_depthfirstsearch(text,bigint,boolean,bigint) | ||
| pgr_dijkstracostmatrix(text,anyarray,boolean) | ||
| pgr_dijkstracost(text,anyarray,anyarray,boolean) | ||
| pgr_dijkstracost(text,anyarray,bigint,boolean) | ||
| pgr_dijkstracost(text,bigint,anyarray,boolean) | ||
| pgr_dijkstracost(text,bigint,bigint,boolean) | ||
| pgr_dijkstracost(text,text,boolean) | ||
| pgr_dijkstranearcost(text,anyarray,anyarray,boolean,bigint,boolean) | ||
| pgr_dijkstranearcost(text,anyarray,bigint,boolean,bigint) | ||
| pgr_dijkstranearcost(text,bigint,anyarray,boolean,bigint) | ||
| pgr_dijkstranearcost(text,text,boolean,bigint,boolean) | ||
| pgr_dijkstranear(text,anyarray,anyarray,boolean,bigint,boolean) | ||
| pgr_dijkstranear(text,anyarray,bigint,boolean,bigint) | ||
| pgr_dijkstranear(text,bigint,anyarray,boolean,bigint) | ||
| pgr_dijkstranear(text,text,boolean,bigint,boolean) | ||
| pgr_dijkstra(text,anyarray,anyarray,boolean) | ||
| pgr_dijkstra(text,anyarray,bigint,boolean) | ||
| pgr_dijkstra(text,bigint,anyarray,boolean) | ||
| pgr_dijkstra(text,bigint,bigint,boolean) | ||
| pgr_dijkstra(text,text,boolean) | ||
| _pgr_dijkstra_v4(text,anyarray,anyarray,boolean,boolean,boolean,bigint,boolean) | ||
| _pgr_dijkstra_v4(text,text,boolean,boolean,bigint,boolean) | ||
| _pgr_dijkstravia(text,anyarray,boolean,boolean,boolean) | ||
| pgr_dijkstravia(text,anyarray,boolean,boolean,boolean) | ||
| pgr_drivingdistance(text,anyarray,double precision,boolean,boolean) | ||
| pgr_drivingdistance(text,bigint,double precision,boolean) | ||
| _pgr_drivingdistancev4(text,anyarray,double precision,boolean,boolean) | ||
| _pgr_edgecoloring(text) | ||
| pgr_edgecoloring(text) | ||
| _pgr_edgedisjointpaths(text,anyarray,anyarray,boolean) | ||
| pgr_edgedisjointpaths(text,anyarray,anyarray,boolean) | ||
| pgr_edgedisjointpaths(text,anyarray,bigint,boolean) | ||
| pgr_edgedisjointpaths(text,bigint,anyarray,boolean) | ||
| pgr_edgedisjointpaths(text,bigint,bigint,boolean) | ||
| _pgr_edgedisjointpaths(text,text,boolean) | ||
| pgr_edgedisjointpaths(text,text,boolean) | ||
| pgr_edmondskarp(text,anyarray,anyarray) | ||
| pgr_edmondskarp(text,anyarray,bigint) | ||
| pgr_edmondskarp(text,bigint,anyarray) | ||
| pgr_edmondskarp(text,bigint,bigint) | ||
| pgr_edmondskarp(text,text) | ||
| _pgr_edwardmoore(text,anyarray,anyarray,boolean) | ||
| pgr_edwardmoore(text,anyarray,anyarray,boolean) | ||
| pgr_edwardmoore(text,anyarray,bigint,boolean) | ||
| pgr_edwardmoore(text,bigint,anyarray,boolean) | ||
| pgr_edwardmoore(text,bigint,bigint,boolean) | ||
| _pgr_edwardmoore(text,text,boolean) | ||
| pgr_edwardmoore(text,text,boolean) | ||
| pgr_extractvertices(text,boolean) | ||
| pgr_findcloseedges(text,geometry,double precision,integer,boolean) | ||
| pgr_findcloseedges(text,geometry[],double precision,integer,boolean) | ||
| _pgr_floydwarshall(text,boolean) | ||
| pgr_floydwarshall(text,boolean) | ||
| pgr_full_version() | ||
| _pgr_get_statement(text) | ||
| _pgr_git_hash() | ||
| _pgr_hawickcircuits(text) | ||
| pgr_hawickcircuits(text) | ||
| _pgr_isplanar(text) | ||
| pgr_isplanar(text) | ||
| _pgr_johnson(text,boolean) | ||
| pgr_johnson(text,boolean) | ||
| _pgr_kingordering(text) | ||
| pgr_kingordering(text) | ||
| pgr_kruskalbfs(text,anyarray,bigint) | ||
| pgr_kruskalbfs(text,bigint,bigint) | ||
| pgr_kruskaldd(text,anyarray,double precision) | ||
| pgr_kruskaldd(text,anyarray,numeric) | ||
| pgr_kruskaldd(text,bigint,double precision) | ||
| pgr_kruskaldd(text,bigint,numeric) | ||
| pgr_kruskaldfs(text,anyarray,bigint) | ||
| pgr_kruskaldfs(text,bigint,bigint) | ||
| pgr_kruskal(text) | ||
| _pgr_kruskalv4(text,anyarray,text,bigint,double precision) | ||
| pgr_ksp(text,anyarray,anyarray,integer,boolean,boolean) | ||
| pgr_ksp(text,anyarray,bigint,integer,boolean,boolean) | ||
| pgr_ksp(text,bigint,anyarray,integer,boolean,boolean) | ||
| pgr_ksp(text,bigint,bigint,integer,boolean,boolean) | ||
| pgr_ksp(text,text,integer,boolean,boolean) | ||
| _pgr_ksp_v4(text,anyarray,anyarray,integer,boolean,boolean) | ||
| _pgr_ksp_v4(text,text,integer,boolean,boolean) | ||
| _pgr_lengauertarjandominatortree(text,bigint) | ||
| pgr_lengauertarjandominatortree(text,bigint) | ||
| _pgr_lib_version() | ||
| _pgr_linegraphfull(text) | ||
| pgr_linegraphfull(text) | ||
| _pgr_linegraph(text,boolean) | ||
| pgr_linegraph(text,boolean) | ||
| _pgr_makeconnected(text) | ||
| pgr_makeconnected(text) | ||
| pgr_maxcardinalitymatch(text) | ||
| _pgr_maxcardinalitymatch_v4(text) | ||
| pgr_maxflowmincost_cost(text,anyarray,anyarray) | ||
| pgr_maxflowmincost_cost(text,anyarray,bigint) | ||
| pgr_maxflowmincost_cost(text,bigint,anyarray) | ||
| pgr_maxflowmincost_cost(text,bigint,bigint) | ||
| pgr_maxflowmincost_cost(text,text) | ||
| pgr_maxflowmincost(text,anyarray,anyarray) | ||
| _pgr_maxflowmincost(text,anyarray,anyarray,boolean) | ||
| pgr_maxflowmincost(text,anyarray,bigint) | ||
| pgr_maxflowmincost(text,bigint,anyarray) | ||
| pgr_maxflowmincost(text,bigint,bigint) | ||
| pgr_maxflowmincost(text,text) | ||
| _pgr_maxflowmincost(text,text,boolean) | ||
| pgr_maxflow(text,anyarray,anyarray) | ||
| _pgr_maxflow(text,anyarray,anyarray,integer,boolean) | ||
| pgr_maxflow(text,anyarray,bigint) | ||
| pgr_maxflow(text,bigint,anyarray) | ||
| pgr_maxflow(text,bigint,bigint) | ||
| pgr_maxflow(text,text) | ||
| _pgr_maxflow(text,text,integer,boolean) | ||
| _pgr_operating_system() | ||
| _pgr_parameter_check(text,text,boolean) | ||
| _pgr_pgsql_version() | ||
| _pgr_pickdelivereuclidean(text,text,double precision,integer,integer) | ||
| pgr_pickdelivereuclidean(text,text,double precision,integer,integer) | ||
| _pgr_pickdeliver(text,text,text,double precision,integer,integer) | ||
| pgr_pickdeliver(text,text,text,double precision,integer,integer) | ||
| pgr_primbfs(text,anyarray,bigint) | ||
| pgr_primbfs(text,bigint,bigint) | ||
| pgr_primdd(text,anyarray,double precision) | ||
| pgr_primdd(text,anyarray,numeric) | ||
| pgr_primdd(text,bigint,double precision) | ||
| pgr_primdd(text,bigint,numeric) | ||
| pgr_primdfs(text,anyarray,bigint) | ||
| pgr_primdfs(text,bigint,bigint) | ||
| pgr_prim(text) | ||
| _pgr_primv4(text,anyarray,text,bigint,double precision) | ||
| pgr_pushrelabel(text,anyarray,anyarray) | ||
| pgr_pushrelabel(text,anyarray,bigint) | ||
| pgr_pushrelabel(text,bigint,anyarray) | ||
| pgr_pushrelabel(text,bigint,bigint) | ||
| pgr_pushrelabel(text,text) | ||
| pgr_separatecrossing(text,double precision,boolean) | ||
| pgr_separatetouching(text,double precision,boolean) | ||
| _pgr_sequentialvertexcoloring(text) | ||
| pgr_sequentialvertexcoloring(text) | ||
| _pgr_sloanordering(text) | ||
| pgr_sloanordering(text) | ||
| _pgr_stoerwagner(text) | ||
| pgr_stoerwagner(text) | ||
| _pgr_strongcomponents(text) | ||
| pgr_strongcomponents(text) | ||
| _pgr_topologicalsort(text) | ||
| pgr_topologicalsort(text) | ||
| _pgr_transitiveclosure(text) | ||
| pgr_transitiveclosure(text) | ||
| pgr_trsp(text,text,anyarray,anyarray,boolean) | ||
| pgr_trsp(text,text,anyarray,bigint,boolean) | ||
| pgr_trsp(text,text,bigint,anyarray,boolean) | ||
| pgr_trsp(text,text,bigint,bigint,boolean) | ||
| pgr_trsp(text,text,text,boolean) | ||
| _pgr_trspv4(text,text,anyarray,anyarray,boolean) | ||
| _pgr_trspv4(text,text,text,boolean) | ||
| _pgr_trspvia(text,text,anyarray,boolean,boolean,boolean) | ||
| pgr_trspvia(text,text,anyarray,boolean,boolean,boolean) | ||
| pgr_trspvia_withpoints(text,text,text,anyarray,boolean,boolean,boolean,boolean) | ||
| pgr_trspvia_withpoints(text,text,text,anyarray,character,boolean,boolean,boolean,boolean) | ||
| _pgr_trspvia_withpoints_v4(text,text,text,anyarray,boolean,boolean,boolean,character,boolean) | ||
| pgr_trsp_withpoints(text,text,text,anyarray,anyarray,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,anyarray,anyarray,character,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,anyarray,bigint,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,anyarray,bigint,character,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,bigint,anyarray,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,bigint,anyarray,character,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,bigint,bigint,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,bigint,bigint,character,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,text,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,text,character,boolean,boolean) | ||
| _pgr_trsp_withpoints_v4(text,text,text,anyarray,anyarray,boolean,character,boolean) | ||
| _pgr_trsp_withpoints_v4(text,text,text,text,boolean,character,boolean) | ||
| pgr_tspeuclidean(text,bigint,bigint) | ||
| _pgr_tspeuclidean_v4(text,bigint,bigint) | ||
| pgr_tsp(text,bigint,bigint) | ||
| _pgr_tsp_v4(text,bigint,bigint) | ||
| pgr_turnrestrictedpath(text,text,bigint,bigint,integer,boolean,boolean,boolean,boolean) | ||
| _pgr_turnrestrictedpath_v4(text,text,anyarray,anyarray,integer,boolean,boolean,boolean,boolean) | ||
| pgr_version() | ||
| _pgr_vrponedepot(text,text,text,integer) | ||
| pgr_vrponedepot(text,text,text,integer) | ||
| pgr_withpointscostmatrix(text,text,anyarray,boolean) | ||
| pgr_withpointscostmatrix(text,text,anyarray,character,boolean) | ||
| pgr_withpointscost(text,text,anyarray,anyarray,boolean) | ||
| pgr_withpointscost(text,text,anyarray,anyarray,character,boolean) | ||
| pgr_withpointscost(text,text,anyarray,bigint,boolean) | ||
| pgr_withpointscost(text,text,anyarray,bigint,character,boolean) | ||
| pgr_withpointscost(text,text,bigint,anyarray,boolean) | ||
| pgr_withpointscost(text,text,bigint,anyarray,character,boolean) | ||
| pgr_withpointscost(text,text,bigint,bigint,boolean) | ||
| pgr_withpointscost(text,text,bigint,bigint,character,boolean) | ||
| pgr_withpointscost(text,text,text,boolean) | ||
| pgr_withpointscost(text,text,text,character,boolean) | ||
| pgr_withpointsdd(text,text,anyarray,double precision,boolean,boolean,boolean) | ||
| pgr_withpointsdd(text,text,anyarray,double precision,character,boolean,boolean,boolean) | ||
| pgr_withpointsdd(text,text,bigint,double precision,boolean,boolean) | ||
| pgr_withpointsdd(text,text,bigint,double precision,character,boolean,boolean) | ||
| _pgr_withpointsddv4(text,text,anyarray,double precision,character,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,anyarray,anyarray,integer,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,anyarray,anyarray,integer,character,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,anyarray,bigint,integer,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,anyarray,bigint,integer,character,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,bigint,anyarray,integer,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,bigint,anyarray,integer,character,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,bigint,bigint,integer,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,bigint,bigint,integer,character,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,text,integer,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,text,integer,character,boolean,boolean,boolean) | ||
| _pgr_withpointsksp_v4(text,text,anyarray,anyarray,integer,character,boolean,boolean,boolean) | ||
| _pgr_withpointsksp_v4(text,text,text,integer,character,boolean,boolean,boolean) | ||
| pgr_withpoints(text,text,anyarray,anyarray,boolean,boolean) | ||
| _pgr_withpoints(text,text,anyarray,anyarray,boolean,character,boolean,boolean,boolean) | ||
| pgr_withpoints(text,text,anyarray,anyarray,character,boolean,boolean) | ||
| pgr_withpoints(text,text,anyarray,bigint,boolean,boolean) | ||
| pgr_withpoints(text,text,anyarray,bigint,character,boolean,boolean) | ||
| pgr_withpoints(text,text,bigint,anyarray,boolean,boolean) | ||
| pgr_withpoints(text,text,bigint,anyarray,character,boolean,boolean) | ||
| pgr_withpoints(text,text,bigint,bigint,boolean,boolean) | ||
| pgr_withpoints(text,text,bigint,bigint,character,boolean,boolean) | ||
| pgr_withpoints(text,text,text,boolean,boolean) | ||
| _pgr_withpoints(text,text,text,boolean,character,boolean,boolean) | ||
| pgr_withpoints(text,text,text,character,boolean,boolean) | ||
| _pgr_withpoints_v4(text,text,anyarray,anyarray,boolean,character,boolean,boolean,boolean,bigint,boolean) | ||
| _pgr_withpoints_v4(text,text,text,boolean,character,boolean,boolean,bigint,boolean) | ||
| pgr_withpointsvia(text,text,anyarray,boolean,boolean,boolean,boolean) | ||
| pgr_withpointsvia(text,text,anyarray,character,boolean,boolean,boolean,boolean) | ||
| _pgr_withpointsvia_v4(text,text,anyarray,boolean,boolean,boolean,character,boolean) |
There was a problem hiding this comment.
Significant scope mismatch: Version bump not mentioned in PR description.
This PR adds an extensive new signature file for pgRouting 4.1 containing 330 function signatures, yet the PR title only mentions "Added Kunal Chandola to Contributors List" and the description is a generic template. This represents a major version bump (4.0 → 4.1) that should be:
- Clearly documented in the PR description
- Reviewed as a version bump PR, not a contributor addition PR
- Accompanied by corresponding code changes and migration documentation
🤖 Prompt for AI Agents
In sql/sigs/pgrouting--4.1.sig around lines 1 to 330: this change adds an entire
pgRouting 4.1 signature file (a version bump) but the PR title/description only
mentions a contributor addition; update the PR to reflect the version bump by
(1) changing the PR title and description to explicitly state "pgRouting 4.1
signatures / version bump" and list the file added, (2) split this large
signature addition into a dedicated PR if possible so the contributor change is
separate, (3) include links to any code changes, release notes or migration
instructions required for 4.1 and reference tests that validate the new
signatures, and (4) tag reviewers for a version/migration review and add a
changelog entry documenting the bump.
KC1706
changed the title
Update locale file to match CMakeLists.txt version definition
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
locale/pot/pgrouting_doc_strings.pot (1)
6913-6915: Upgrade sentence now matches 4.1.0-dev extension versionThe msgid has been updated to “version 4.1.0-dev…”, which resolves the earlier mismatch with the shipped extension version noted in the previous review.
🧹 Nitpick comments (1)
locale/pot/pgrouting_doc_strings.pot (1)
14995-15004: 4.1 release notes block looks consistent; remember to update laterThe new “pgRouting 4.1 / 4.1.0 Release Notes” entries and milestone link are consistent with the version bump; the “No changes yet” placeholder is fine for a dev cycle but should be revised once actual changes exist.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
locale/pot/pgrouting_doc_strings.pot
🔇 Additional comments (2)
locale/pot/pgrouting_doc_strings.pot (2)
2-11: Header metadata correctly bumped to 4.1
Copyright,Project-Id-Version, andPOT-Creation-Dateare aligned with the 4.1 documentation cycle; no issues from a versioning perspective.
3523-3525: 4.0 release header remains valid as historical sectionKeeping the “pgRouting 4.0” msgid here alongside the new 4.1 section makes sense for prior minor-release notes; nothing to change.
4 participants
Summary
This PR bumps pgRouting from version 4.0.0 to 4.1.0-dev and adds Kunal Chandola to the contributors list.
Changes
Testing
@pgRouting/admins
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.