Not setting the full dialect and driver for CONFIG_DATABASE_URI
in case of an external DB currently breaks the docker image
#8107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using PostgreSQL for pgAdmin's config database, SQLAlchemy 2.0+ requires the 'psycopg' dialect vs. 'psycopg2' or 'psycopg3':
Problem:
When setting
PGADMIN_CONFIG_CONFIG_DATABASE_URI
in Docker env to eitherpostgresql://...
orpostgresql+psycopg3://...
we either hitsqlalchemy.exc.NoSuchModuleError: Can't load plugin: sqlalchemy.dialects:postgresql.psycopg3
orModuleNotFoundError: No module named 'psycopg2'
.This PR ensures proper DBAPI postgresql dialect handling for both initial container validation (via entrypoint) and runtime connections for an external postgres config database.
I chose this route because
Let me know if you prefer a different approach. Might have overlooked something / duplicate code isn't nice. Thanks.