Add Postgis Geography codec#727
Open
mdedetrich wants to merge 1 commit into
Open
Conversation
3ec52e3 to
64f447d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that:
Issue description
Resolves: #528
New Public APIs
PostgisGeographyCodec(if this counts as an API).Additional context
Note that the implementation does have a fair bit of boilerplate due to
PostgisGeographyCodecbeing final and hence not being able to be subclassed. One alternative would be to have a package private implementation that bothPostgisGeographyCodecandPostgisGeometryCodeccan share (that way bothPostgisGeographyCodecandPostgisGeometryCodeccan be final).As suggested in the linked github issue, the implementation is just a copy paste of
PostgisGeometryCodecthat also uses theorg.locationtech.jts.geom.Geometrybut this allows you to decode postgresgeographytypes.