Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference java source files with absolute path in Makefile. #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbanck-cd
Copy link

This allows for out-of-tree builds, fixing issue #39.

This allows for out-of-tree builds, fixing issue pgspider#39.
@MinhLA1410
Copy link
Contributor

MinhLA1410 commented Oct 23, 2024

Hello @mbanck-ntap ,
I checked your PR and it tried to use new Makefile variable srcdir when build jdbc_fdw with Postgres source tree
The error happens.
Maybe srcdir is a global variable of postgres, could you please check it?

Proceduce:

cd home/vagrant/workplace/postgresql-xxx/contrib
git clone path/to/jdbc_fdw
cd jdbc_fdw
make srcdir=/home/vagrant/workplace/postgresql-xxx/contrib/jdbc_fdw

Output:

[vagrant@localhost jdbc_fdw]$ make srcdir=/home/vagrant/workplace/postgresql-xxx/contrib/jdbc_fdw
make -C ../../src/backend generated-headers
make[1]: Entering directory '/home/vagrant/workplace/postgresql-xxx/src/backend'
Makefile:26: /home/vagrant/workplace/postgresql-xxx/contrib/jdbc_fdw/common.mk: No such file or directory
make[1]: *** No rule to make target '/home/vagrant/workplace/postgresql-xxx/contrib/jdbc_fdw/common.mk'.  Stop.
make[1]: Leaving directory '/home/vagrant/workplace/postgresql-xxx/src/backend'
make: *** [../../src/Makefile.global:384: submake-generated-headers] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants