Utility analysis ignore the "no tests" warning#125
Merged
guillep merged 3 commits intopharo-contributions:masterfrom Feb 18, 2025
Merged
Utility analysis ignore the "no tests" warning#125guillep merged 3 commits intopharo-contributions:masterfrom
guillep merged 3 commits intopharo-contributions:masterfrom
Conversation
guillep
requested changes
Feb 17, 2025
Contributor
There was a problem hiding this comment.
hi Pol! this is a very good idea!
I was thinking, what if, instead of ignoring the warning on the caller we have a setting on the MTAnalysis class?
Personally, I don't like this warning :)
So, we could have a setting warnAboutEmptyAnalysis that could be true by default (to keep compat), and, if true it raises the warning (and not if false).
What do you think?
Collaborator
Author
|
I think this is a better approach to the problem for sure ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123
Those analysis don't use tests, so the warning should not interrupt them.
The current solution is certainly not perfect, so I'm open to better implementation idea.