Pharo14 compatibility#132
Merged
guillep merged 4 commits intopharo-contributions:masterfrom Feb 23, 2026
Merged
Conversation
Contributor
|
Hmm it looks like the CI is broken, would you mind looking at it @DurieuxPol ? |
Contributor
|
Still breaking for Pharo 10! :) |
Collaborator
Author
|
I checked every Pharo versions from 9 to 14 and for each one of them the tests are green. The only red test is in Pharo9 because Microdown is not available, but this issue is already open. |
Contributor
|
Hmm, ok, then I propose we integrate this and fix the microdown just after to not block this PR. Options:
@DurieuxPol thoughts? |
Collaborator
Author
|
We can skip the failing test for Pharo 9 only, by checking the Pharo version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for pharo14 compatibility