Skip to content

fix: make OnlineSourceDebugInfo>>#readVariableNamed:fromContext: work… #18719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: Pharo14
Choose a base branch
from
+19 −1
Open

fix: make OnlineSourceDebugInfo>>#readVariableNamed:fromContext: work… #18719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/DebugInfo-Tests/DebugInfoTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,6 +825,24 @@ DebugInfoTest >> testReadLocalMethodTemporaryVariable [
equals: contextWithArguments
]

{ #category : 'tests - read variables' }
DebugInfoTest >> testReadLocalMethodTemporaryVariableFromDeadContext [

| debugInfo contextWithArguments |
contextWithArguments := thisContext copy
pc: nil;
yourself.
self assert: contextWithArguments isDead.
debugInfo := self newDebugInfoFor: contextWithArguments method.

self
shouldnt: [
debugInfo
readVariableNamed: #contextWithArguments
fromContext: contextWithArguments ]
raise: MessageNotUnderstood
]

{ #category : 'tests - read variables' }
DebugInfoTest >> testReadLocalOptimizedBlockArgumentVariable [

Expand Down
2 changes: 1 addition & 1 deletion src/DebugInfo/OnlineSourceDebugInfo.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ OnlineSourceDebugInfo >> rangeForPC: aPC [
{ #category : 'api' }
OnlineSourceDebugInfo >> readVariableNamed: aName fromContext: aContext [

^ (self debugScopeAt: aContext pc) readVariableNamed: aName fromContext: aContext
^ (self debugScopeAt: aContext currentPC) readVariableNamed: aName fromContext: aContext
]

{ #category : 'api' }
Expand Down