Make parser fail when a statement follows a return. #18767
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…18607 FIxes: pharo-project#18607 Making that parser will fail when a statement follows a return.
Ducasse
changed the title
demarey
changed the title
demarey
reviewed
Oct 27, 2025
src/AST-Core/OCParser.class.st
Outdated
|
|
||
| (statementList notEmpty and: [ statementList last isReturn ]) ifTrue: [ | ||
| node addWarning: 'Unreachable statement' ]. | ||
| self error: 'After the return statement, there is an unreachable statement in this method source: ', source ]. |
Contributor
There was a problem hiding this comment.
It is nice but will it forbid to have a comment after the return
Member
Author
|
Yes I was thinking that we could turn the expression into a comment. I started to play with it but I could not find how to have a position of the expression so that I can set the comment position. |
Member
|
I close this, as we should not raise an Error, but instead annotate the AST with the error using addError: I will do a PR with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making that parser will fail when a statement follows a return.