Cut dependency of Collection-Strings to Unicode #18826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Collections-Strings depends explicitly on Unicode. It would lead to error to move the methods as extension of Unicode because the error would not be clear. I propose to make the dependency weaker by checking if unicode is in the image and raise a right warning if it is not in the image.
|
I was thinking that we could have a package with WideStrin and unicode together? |
I wanted to do that but WideString is too tight to String. It'd be really hard to get it out |
demarey
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Collections-Strings depends explicitly on Unicode. It would lead to error to move the methods as extension of Unicode because the error would not be clear. I propose to make the dependency weaker by checking if unicode is in the image and raise a right warning if it is not in the image.