Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
79e30d2
Get the real value when getting a setting presenter from a setting de…
hernanmd Nov 7, 2024
727a34b
Merge branch 'pharo-spec:Pharo13' into p13-settings-browser-support
hernanmd Nov 8, 2024
03166c3
Add support for logging setting updates
hernanmd Nov 8, 2024
a8a0605
Merge 727a34b846d85fa377ad3c51302f32b2b8cb5be5
hernanmd Nov 8, 2024
8cf9483
Merge branch 'pharo-spec:Pharo13' into p13-settings-browser-support
hernanmd Nov 13, 2024
e7498c5
Merge branch 'pharo-spec:Pharo13' into p13-settings-browser-support
hernanmd Nov 15, 2024
cc0a4f2
Initialize the application before super initialization that needs the…
hernanmd Nov 15, 2024
d76f313
Add mocks for testing setting updates
hernanmd Nov 15, 2024
6ca3a6d
Add settings tracker mocks and tests
hernanmd Nov 15, 2024
6809bda
Merge branch 'Pharo13' into p13-settings-browser-support
hernanmd Nov 17, 2024
dd88eac
Add update setting blocks for tracking changes
hernanmd Nov 18, 2024
100fd90
Simplify settings events storage for now
hernanmd Nov 18, 2024
f9cb2b7
Simplify tests
hernanmd Nov 18, 2024
59fc8d6
Adding tests
hernanmd Nov 18, 2024
dc7f2cb
Merge branch 'pharo-spec:Pharo13' into p13-settings-browser-support
hernanmd Nov 19, 2024
683e870
Add a tracker for updated settings.
hernanmd Nov 19, 2024
1f37706
Merge branch 'pharo-spec:Pharo13' into p13-settings-browser-support
hernanmd Nov 19, 2024
420784d
Use submit events for text input presenters.
Nov 20, 2024
cfe453a
Add button to open changed settings history
Nov 20, 2024
9f4f02a
Fix unused variables
Nov 20, 2024
021023e
Merge branch 'pharo-spec:Pharo13' into p13-settings-browser-support
hernanmd Nov 21, 2024
dc17239
Update session log initialization
Nov 21, 2024
410cdfe
Reset setting history before running tests (this is a temporary solut…
Nov 21, 2024
d145483
Merge branch 'pharo-spec:Pharo13' into p13-settings-browser-support
hernanmd Nov 25, 2024
2238ce0
Disable boolean test (test green in the interactive env but CI fails)
Nov 25, 2024
ab1b5d3
Remove unnecessary method
Nov 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/NewTools-SettingsBrowser/SettingDeclaration.extension.st
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ SettingDeclaration >> asSettingPresenter [
"Answer an appropriate <SpPresenter> container for the receiver's value"

^ self precondition value
ifTrue: [ self default asSettingPresenter: self ]
ifTrue: [
self hasValue
ifTrue: [ self realValue asSettingPresenter: self ]
ifFalse: [ self default asSettingPresenter: self ] ]
ifFalse: [ SpNullPresenter new ]
]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,17 @@ Class {
{ #category : 'initialization' }
StSettingBooleanPresenterItem >> initializePresenters [

setterPresenter := self newCheckBox
setterPresenter := self newCheckBox.
setterPresenter
state: self model realValue;
whenActivatedDo: [ self updateSetting: self model value: true ];
whenDeactivatedDo: [ self updateSetting: self model value: false ].
whenDeactivatedDo: [ self updateSetting: self model value: false ];
whenChangedDo: [ : newValue : oldValue |
newValue = oldValue ifFalse: [
self announcer announce: (SettingUpdated
declaration: self model
oldValue: oldValue
newValue: newValue) ] ].
super initializePresenters.

]
Expand Down Expand Up @@ -43,5 +51,6 @@ StSettingBooleanPresenterItem >> updateSetting: aSettingDeclaration value: aBool
{ #category : 'accessing' }
StSettingBooleanPresenterItem >> value: aBoolean [

self setterPresenter state: aBoolean
self setterPresenter state: aBoolean.

]
14 changes: 14 additions & 0 deletions src/NewTools-SettingsBrowser/StSettingPresenterItem.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@ Class {
#tag : 'Widgets'
}

{ #category : 'accessing' }
StSettingPresenterItem >> announcer [
"Answer a <SystemAnnouncer> to notify receiver changes"

^ self environment codeSupportAnnouncer

]

{ #category : 'layout' }
StSettingPresenterItem >> defaultLayout [

Expand All @@ -26,6 +34,12 @@ StSettingPresenterItem >> defaultLayout [
yourself
]

{ #category : 'initialization' }
StSettingPresenterItem >> environment [

^ SystemEnvironment new
]

{ #category : 'initialization' }
StSettingPresenterItem >> initializePresenters [
"Set a label and description presenters as baseline for every setting"
Expand Down
Loading