-
Notifications
You must be signed in to change notification settings - Fork 74
Add basic event support for setting events #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hernanmd
wants to merge
26
commits into
pharo-spec:Pharo13
Choose a base branch
from
hernanmd:p13-settings-browser-support
base: Pharo13
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
79e30d2
Get the real value when getting a setting presenter from a setting de…
hernanmd 727a34b
Merge branch 'pharo-spec:Pharo13' into p13-settings-browser-support
hernanmd 03166c3
Add support for logging setting updates
hernanmd a8a0605
Merge 727a34b846d85fa377ad3c51302f32b2b8cb5be5
hernanmd 8cf9483
Merge branch 'pharo-spec:Pharo13' into p13-settings-browser-support
hernanmd e7498c5
Merge branch 'pharo-spec:Pharo13' into p13-settings-browser-support
hernanmd cc0a4f2
Initialize the application before super initialization that needs the…
hernanmd d76f313
Add mocks for testing setting updates
hernanmd 6ca3a6d
Add settings tracker mocks and tests
hernanmd 6809bda
Merge branch 'Pharo13' into p13-settings-browser-support
hernanmd dd88eac
Add update setting blocks for tracking changes
hernanmd 100fd90
Simplify settings events storage for now
hernanmd f9cb2b7
Simplify tests
hernanmd 59fc8d6
Adding tests
hernanmd dc7f2cb
Merge branch 'pharo-spec:Pharo13' into p13-settings-browser-support
hernanmd 683e870
Add a tracker for updated settings.
hernanmd 1f37706
Merge branch 'pharo-spec:Pharo13' into p13-settings-browser-support
hernanmd 420784d
Use submit events for text input presenters.
cfe453a
Add button to open changed settings history
9f4f02a
Fix unused variables
021023e
Merge branch 'pharo-spec:Pharo13' into p13-settings-browser-support
hernanmd dc17239
Update session log initialization
410cdfe
Reset setting history before running tests (this is a temporary solut…
d145483
Merge branch 'pharo-spec:Pharo13' into p13-settings-browser-support
hernanmd 2238ce0
Disable boolean test (test green in the interactive env but CI fails)
ab1b5d3
Remove unnecessary method
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.