Skip to content

Conversation

rohan-chaturvedi
Copy link
Member

@rohan-chaturvedi rohan-chaturvedi commented Aug 14, 2025

🔍 Overview

Adds support for multi-line secrets like PGP keys, certs, etc.

Fixes #642

💡 Proposed Changes

  • Updated the secret editor UI to support multi-line secrets
  • Updated the import parser to detect and import multi-line secrets
  • Moved the comment button beside the secret key, and display a comment if available as the button label

🖼️ Screenshots or Demo

Screencast.From.2025-08-14.15-24-44.mp4

🎯 Reviewer Focus

  • Test adding / updating both single and multi-line secrets on the single and cross env screens
  • Test imports of single and multi-line secrets on the single and cross-env screens
  • Test compatibility for multi-line secrets with the CLI

💚 Did You...

  • Ensure linting passes (code style checks)?
    - [ ] Update dependencies and lockfiles (if required)
    - [ ] Update migrations (if required)
    - [ ] Regenerate graphql schema and types (if required)
  • Verify the app builds locally?
  • Manually test the changes on different browsers/devices?

@rohan-chaturvedi rohan-chaturvedi added enhancement New feature or request frontend Change in frontend code labels Aug 14, 2025
@nimish-ks
Copy link
Member

@rohan-chaturvedi Awesome work!

Notes from the PR demo:

  • Pressing Tab from the secret key field should move focus to the value field (not comment button)
  • Accommodate the secret tag and comment buttons / indicators in a more compact way on smaller screens. A long comment should never overlap and obstruct a secret key.
  • Lets always make room for the secret key, on narrower screens maybe collapse the tag and comment buttons to just simple icon indicators 🏷️ and #️⃣. Color the icons to indicate an attached tag or a comment.

@nimish-ks
Copy link
Member

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Change in frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiline secrets
2 participants