Skip to content

Conversation

nimish-ks
Copy link
Member

@nimish-ks nimish-ks commented Aug 30, 2025

🔍 Overview

Misc fixes and improvements Add App component.

💡 Proposed Changes

  • Focus cursor on input field when the Add App search box is triggered
  • Clear search state and focus cursor component reopen
  • Make sure to normalize search query to match for App names like App.Payments.API with 'App.P...'

🖼️ Screenshots or Demo

Before

image

After:

image

@nimish-ks nimish-ks self-assigned this Aug 30, 2025
@nimish-ks nimish-ks changed the title fix: app search component fix: Add App search component Aug 30, 2025
@nimish-ks
Copy link
Member Author

@cursor review

@@ -69,6 +74,8 @@ export const AddAppButton = ({
'absolute z-10 mt-2',
alignMenuRight ? 'origin-bottom-left left-0' : 'origin-bottom-right right-0'
)}
afterEnter={() => searchInputRef.current?.focus()}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Redundant Focus Logic in AddAppButton

The AddAppButton component has redundant search input focus logic. The button's onClick handler uses setTimeout to focus the input, but this runs before the menu is rendered, creating a race condition. The Transition's afterEnter callback correctly focuses the input once the menu is visible, making the onClick handler unnecessary.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant