feat: Add analyzer PH2162 and code fix for TestTimeouts class accessibility

[Copilot]

This PR implements a new Roslyn analyzer that enforces proper accessibility modifiers for classes named "TestTimeouts" used in MSTest projects.

Problem

Classes named TestTimeouts that contain test timeout constants are often declared with inappropriate accessibility modifiers, which can lead to:

• Unnecessary public exposure of test infrastructure
• Inconsistent accessibility patterns across test projects
• Potential conflicts when classes are marked as internal static
• Conflicts with the MSTest analyzer that restricts all classes in test projects from being public unless they have the [TestClass] attribute

Solution

Added TestTimeoutsClassAccessibilityAnalyzer (PH2162) that detects and provides automatic fixes for:

• public class TestTimeouts → internal class TestTimeouts
• public sealed class TestTimeouts → internal sealed class TestTimeouts
• internal static class TestTimeouts → internal class TestTimeouts

The analyzer ignores classes that are already properly declared as internal (non-static) and only targets classes specifically named "TestTimeouts".

Example

Before:

public class TestTimeouts
{
    public const int CiAppropriate = 1000;
    public const int Integration = 5000;
}

After (with code fix applied):

internal class TestTimeouts
{
    public const int CiAppropriate = 1000;
    public const int Integration = 5000;
}

Changes Made

• DiagnosticId.cs: Added TestTimeoutsClassShouldBeInternal = 2162
• TestTimeoutsClassAccessibilityAnalyzer.cs: New analyzer that detects problematic accessibility modifiers
• TestTimeoutsClassAccessibilityCodeFixProvider.cs: Automatic code fix that corrects the modifiers
• TestTimeoutsClassAccessibilityAnalyzerTest.cs: Comprehensive test coverage for all scenarios
• PH2162.md: Documentation explaining the rule and how it helps avoid MSTest analyzer conflicts

The analyzer is enabled by default and includes full test coverage with 6 test cases covering all supported scenarios. All existing tests (369 MSTest-related tests) continue to pass, ensuring no regressions.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Brian Collamore (bcollamore)]

Perhaps mention how this rule helps avoid conflict with the MSTEST analyzer that says all classes in a test project cannot be public unless it's a [TestClass]

[Copilot]

Added mention of the MSTEST analyzer conflict avoidance in the documentation. The rule now explains how it helps avoid conflicts with the MSTest analyzer that restricts all classes in test projects from being public unless they have the [TestClass] attribute. Implemented in commit 439b4e0.

[Brian Collamore (bcollamore)]

Let's use 2162 instead of 2159. 2159, 2160, and 2161 are claimed in other PRs. Remember to update the PH2159.md file name and contents as well.

[Copilot]

Updated diagnostic ID from PH2159 to PH2162 and renamed documentation file accordingly. All references in DiagnosticId.cs and PH2162.md have been updated. Implemented in commit 439b4e0.

[Brian Collamore (bcollamore)]

Copilot see comments above