Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes that the migration is added even if it fails #23

Closed
wants to merge 4 commits into from
Closed

fixes that the migration is added even if it fails #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
343add5
fixes that the migration is added even if it fails
mribichich Nov 20, 2016
e1e6f34
Environment Architecture anomalies gone
thehoneymad Oct 5, 2016
06f9dd2
updated to mongo 3.2
thehoneymad Oct 3, 2016
3471045
added GuidRepresentation.Standard type 4 instead of legacy
mribichich Nov 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions src/MongoMigrations/CollectionMigration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,14 @@ public CollectionMigration(MigrationVersion version, string collectionName) : ba
CollectionName = collectionName;
}

public virtual IMongoQuery Filter()
{
return null;
}

public override void Update()
{
var collection = GetCollection();
var documents = GetDocuments(collection);
UpdateDocuments(collection, documents);
}

public virtual void UpdateDocuments(MongoCollection<BsonDocument> collection, IEnumerable<BsonDocument> documents)
public virtual void UpdateDocuments(IMongoCollection<BsonDocument> collection, IEnumerable<BsonDocument> documents)
{
foreach (var document in documents)
{
Expand Down Expand Up @@ -55,19 +50,16 @@ protected virtual void OnErrorUpdatingDocument(BsonDocument document, Exception
throw new MigrationException(message.ToString(), exception);
}

public abstract void UpdateDocument(MongoCollection<BsonDocument> collection, BsonDocument document);
public abstract void UpdateDocument(IMongoCollection<BsonDocument> collection, BsonDocument document);

protected virtual MongoCollection<BsonDocument> GetCollection()
protected virtual IMongoCollection<BsonDocument> GetCollection()
{
return Database.GetCollection(CollectionName);
}
return Database.GetCollection<BsonDocument>(CollectionName);
}

protected virtual IEnumerable<BsonDocument> GetDocuments(MongoCollection<BsonDocument> collection)
{
var query = Filter();
return query != null
? collection.Find(query)
: collection.FindAll();
}
}
protected virtual IEnumerable<BsonDocument> GetDocuments(IMongoCollection<BsonDocument> collection)
{
return collection.Find(Builders<BsonDocument>.Filter.Empty).ToList();
}
}
}
9 changes: 4 additions & 5 deletions src/MongoMigrations/DatabaseMigrationStatus.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public DatabaseMigrationStatus(MigrationRunner runner)
_Runner = runner;
}

public virtual MongoCollection<AppliedMigration> GetMigrationsApplied()
public virtual IMongoCollection<AppliedMigration> GetMigrationsApplied()
{
return _Runner.Database.GetCollection<AppliedMigration>(VersionCollectionName);
}
Expand Down Expand Up @@ -48,7 +48,7 @@ public virtual MigrationVersion GetVersion()
public virtual AppliedMigration GetLastAppliedMigration()
{
return GetMigrationsApplied()
.FindAll()
.Find(Builders<AppliedMigration>.Filter.Empty)
.ToList() // in memory but this will never get big enough to matter
.OrderByDescending(v => v.Version)
.FirstOrDefault();
Expand All @@ -57,14 +57,13 @@ public virtual AppliedMigration GetLastAppliedMigration()
public virtual AppliedMigration StartMigration(Migration migration)
{
var appliedMigration = new AppliedMigration(migration);
GetMigrationsApplied().Insert(appliedMigration);
return appliedMigration;
}

public virtual void CompleteMigration(AppliedMigration appliedMigration)
{
appliedMigration.CompletedOn = DateTime.Now;
GetMigrationsApplied().Save(appliedMigration);
GetMigrationsApplied().InsertOne(appliedMigration);
}

public virtual void MarkUpToVersion(MigrationVersion version)
Expand All @@ -78,7 +77,7 @@ public virtual void MarkUpToVersion(MigrationVersion version)
public virtual void MarkVersion(MigrationVersion version)
{
var appliedMigration = AppliedMigration.MarkerOnly(version);
GetMigrationsApplied().Insert(appliedMigration);
GetMigrationsApplied().InsertOne(appliedMigration);
}
}
}
2 changes: 1 addition & 1 deletion src/MongoMigrations/Migration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ protected Migration(MigrationVersion version)
Version = version;
}

public MongoDatabase Database { get; set; }
public IMongoDatabase Database { get; set; }

public abstract void Update();
}
Expand Down
32 changes: 24 additions & 8 deletions src/MongoMigrations/MigrationLocator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ public MigrationLocator()
MigrationFilters.Add(new ExcludeExperimentalMigrations());
}

public IEnumerable<Migration> AllMigrations { get; private set; }

public virtual void LookForMigrationsInAssemblyOfType<T>()
{
var assembly = typeof (T).Assembly;
Expand All @@ -27,18 +29,29 @@ public void LookForMigrationsInAssembly(Assembly assembly)
{
return;
}

Assemblies.Add(assembly);
}

public virtual IEnumerable<Migration> GetAllMigrations()
{
return Assemblies
.SelectMany(GetMigrationsFromAssembly)
.OrderBy(m => m.Version);
if (this.AllMigrations != null && this.AllMigrations.Any())
{
return this.AllMigrations;
}

this.AllMigrations = this.Assemblies
.SelectMany(this.GetMigrationsFromAssembly)
.OrderBy(m => m.Version)
.ToList();

return this.AllMigrations;
}

protected virtual IEnumerable<Migration> GetMigrationsFromAssembly(Assembly assembly)
protected virtual IEnumerable<Migration> GetMigrationsFromAssembly(Assembly assembly)
{
Console.WriteLine($"Getting migrations from assembly: {assembly.FullName}");

try
{
return assembly.GetTypes()
Expand All @@ -55,17 +68,20 @@ protected virtual IEnumerable<Migration> GetMigrationsFromAssembly(Assembly asse

public virtual MigrationVersion LatestVersion()
{
if (!GetAllMigrations().Any())
var allMigrations = this.GetAllMigrations().ToList();

if (!allMigrations.Any())
{
return MigrationVersion.Default();
}
return GetAllMigrations()
.Max(m => m.Version);

return allMigrations
.Max(m => m.Version);
}

public virtual IEnumerable<Migration> GetMigrationsAfter(AppliedMigration currentVersion)
{
var migrations = GetAllMigrations();
var migrations = this.GetAllMigrations();

if (currentVersion != null)
{
Expand Down
203 changes: 105 additions & 98 deletions src/MongoMigrations/MigrationRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,101 +1,108 @@
namespace MongoMigrations
{
using System;
using System.Collections.Generic;
using System.Linq;
using MongoDB.Bson.Serialization;
using MongoDB.Driver;

public class MigrationRunner
{
static MigrationRunner()
{
Init();
}

public static void Init()
{
BsonSerializer.RegisterSerializer(typeof (MigrationVersion), new MigrationVersionSerializer());
}

public MigrationRunner(string mongoServerLocation, string databaseName)
: this(new MongoClient(mongoServerLocation).GetServer().GetDatabase(databaseName))
{
}

public MigrationRunner(MongoDatabase database)
{
Database = database;
DatabaseStatus = new DatabaseMigrationStatus(this);
MigrationLocator = new MigrationLocator();
}

public MongoDatabase Database { get; set; }
public MigrationLocator MigrationLocator { get; set; }
public DatabaseMigrationStatus DatabaseStatus { get; set; }

public virtual void UpdateToLatest()
{
Console.WriteLine(WhatWeAreUpdating() + " to latest...");
UpdateTo(MigrationLocator.LatestVersion());
}

private string WhatWeAreUpdating()
{
return string.Format("Updating server(s) \"{0}\" for database \"{1}\"", ServerAddresses(), Database.Name);
}

private string ServerAddresses()
{
return String.Join(",", Database.Server.Instances.Select(s => s.Address.ToString()));
}

protected virtual void ApplyMigrations(IEnumerable<Migration> migrations)
{
migrations.ToList()
.ForEach(ApplyMigration);
}

protected virtual void ApplyMigration(Migration migration)
{
Console.WriteLine(new {Message = "Applying migration", migration.Version, migration.Description, DatabaseName = Database.Name});

var appliedMigration = DatabaseStatus.StartMigration(migration);
migration.Database = Database;
try
{
migration.Update();
}
catch (Exception exception)
{
OnMigrationException(migration, exception);
}
DatabaseStatus.CompleteMigration(appliedMigration);
}

protected virtual void OnMigrationException(Migration migration, Exception exception)
{
var message = new
{
Message = "Migration failed to be applied: " + exception.Message,
migration.Version,
Name = migration.GetType(),
migration.Description,
DatabaseName = Database.Name
};
Console.WriteLine(message);
throw new MigrationException(message.ToString(), exception);
}

public virtual void UpdateTo(MigrationVersion updateToVersion)
{
var currentVersion = DatabaseStatus.GetLastAppliedMigration();
Console.WriteLine(new {Message = WhatWeAreUpdating(), currentVersion, updateToVersion, DatabaseName = Database.Name});

var migrations = MigrationLocator.GetMigrationsAfter(currentVersion)
.Where(m => m.Version <= updateToVersion);

ApplyMigrations(migrations);
}
}
using System;
using System.Collections.Generic;
using System.Linq;
using MongoDB.Bson.Serialization;
using MongoDB.Driver;

public class MigrationRunner
{
static MigrationRunner()
{
Init();
}

public MigrationRunner(string mongoServerLocation, string databaseName)
: this(new MongoClient(mongoServerLocation).GetDatabase(databaseName))
{
}

public MigrationRunner(IMongoDatabase database)
{
Database = database;
DatabaseStatus = new DatabaseMigrationStatus(this);
MigrationLocator = new MigrationLocator();
}

public static void Init()
{
MongoDefaults.GuidRepresentation = MongoDB.Bson.GuidRepresentation.Standard;

BsonSerializer.RegisterSerializer(typeof(MigrationVersion), new MigrationVersionSerializer());
}

public IMongoDatabase Database { get; set; }

public MigrationLocator MigrationLocator { get; set; }

public DatabaseMigrationStatus DatabaseStatus { get; set; }

public virtual void UpdateToLatest()
{
Console.WriteLine(WhatWeAreUpdating() + " to latest...");

UpdateTo(MigrationLocator.LatestVersion());
}

private string WhatWeAreUpdating()
{
return $"Updating server(s) \"{this.ServerAddresses()}\" for database \"{this.Database.DatabaseNamespace.DatabaseName}\"";
}

private string ServerAddresses()
{
return String.Join(",", Database.Client.Settings.Server.ToString());
}

protected virtual void ApplyMigrations(IEnumerable<Migration> migrations)
{
migrations.ToList()
.ForEach(ApplyMigration);
}

protected virtual void ApplyMigration(Migration migration)
{
Console.WriteLine(new { Message = "Applying migration", migration.Version, migration.Description, DatabaseName = Database.DatabaseNamespace.DatabaseName });

var appliedMigration = DatabaseStatus.StartMigration(migration);
migration.Database = Database;

try
{
migration.Update();

DatabaseStatus.CompleteMigration(appliedMigration);
}
catch (Exception exception)
{
OnMigrationException(migration, exception);
}
}

protected virtual void OnMigrationException(Migration migration, Exception exception)
{
var message = new
{
Message = "Migration failed to be applied: " + exception.Message,
migration.Version,
Name = migration.GetType(),
migration.Description,
DatabaseName = Database.DatabaseNamespace.DatabaseName
};
Console.WriteLine(message);
throw new MigrationException(message.ToString(), exception);
}

public virtual void UpdateTo(MigrationVersion updateToVersion)
{
var currentVersion = DatabaseStatus.GetLastAppliedMigration();
Console.WriteLine(new { Message = WhatWeAreUpdating(), currentVersion, updateToVersion, DatabaseName = Database.DatabaseNamespace.DatabaseName });

var migrations = MigrationLocator.GetMigrationsAfter(currentVersion)
.Where(m => m.Version <= updateToVersion);

ApplyMigrations(migrations);
}
}
}
Loading