Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 52 additions & 2 deletions pkg/rdkafka/RdKafkaContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ public function __construct(array $config)
$this->config = $config;
$this->kafkaConsumers = [];
$this->rdKafkaConsumers = [];

$this->setSerializer(new JsonSerializer());
$this->configureSerializer($config);
}

/**
Expand Down Expand Up @@ -180,6 +179,57 @@ public static function getLibrdKafkaVersion(): string
return "$major.$minor.$patch";
}

/**
* JsonSerializer should be the default fallback if no serializer is specified.
*/
private function configureSerializer(array $config): void
{
if (!isset($config['serializer'])) {
$this->setSerializer(new JsonSerializer());

return;
}

$serializer = $config['serializer'];

if ($serializer instanceof Serializer) {
$this->setSerializer($serializer);

return;
}

$serializerClass = $this->resolveSerializerClass($serializer);

if (!class_exists($serializerClass) || !is_a($serializerClass, Serializer::class, true)) {
throw $this->createInvalidSerializerException($serializerClass);
}

$serializerOptions = $serializer['options'] ?? [];
$this->setSerializer(new $serializerClass($serializerOptions));
}

private function resolveSerializerClass(mixed $serializer): string
{
if (is_string($serializer)) {
return $serializer;
}

if (is_array($serializer) && isset($serializer['class'])) {
return $serializer['class'];
}

throw $this->createInvalidSerializerException($serializer);
}

private function createInvalidSerializerException(mixed $value): \InvalidArgumentException
{
return new \InvalidArgumentException(sprintf(
'Invalid serializer configuration. Expected "serializer" to be a string, an array with a "class" key, or a %s instance. Received %s instead.',
Serializer::class,
get_debug_type($value)
));
}

private function getConf(): Conf
{
if (null === $this->conf) {
Expand Down
2 changes: 2 additions & 0 deletions pkg/rdkafka/RdKafkaProducer.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ public function send(Destination $destination, Message $message): void
*/
public function setDeliveryDelay(?int $deliveryDelay = null): Producer
{
$deliveryDelay = null;

if (null === $deliveryDelay) {
return $this;
}
Expand Down
39 changes: 39 additions & 0 deletions pkg/rdkafka/Tests/RdKafkaContextTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,45 @@ public function testShouldSetJsonSerializerInConstructor()
$this->assertInstanceOf(JsonSerializer::class, $context->getSerializer());
}

public function testShouldUseStringSerializerClassFromConfig()
{
$mockSerializerClass = get_class($this->createMock(Serializer::class));

$context = new RdKafkaContext([
'serializer' => $mockSerializerClass,
]);

$this->assertInstanceOf($mockSerializerClass, $context->getSerializer());
}

public function testShouldUseJsonSerializer()
{
$context = new RdKafkaContext([]);

$this->assertInstanceOf(JsonSerializer::class, $context->getSerializer());
}

public function testShouldPreserveSameSerializerInstanceWhenObjectIsPassed()
{
$serializer = $this->createMock(Serializer::class);

$context = new RdKafkaContext([
'serializer' => $serializer,
]);

$this->assertSame($serializer, $context->getSerializer());
}

public function testShouldThrowExceptionOnInvalidSerializerConfig()
{
$this->expectException(\InvalidArgumentException::class);
$this->expectExceptionMessage('Invalid serializer configuration');

new RdKafkaContext([
'serializer' => 123,
]);
}

public function testShouldAllowGetPreviouslySetSerializer()
{
$context = new RdKafkaContext([]);
Expand Down
Loading