Fix: Use blocking socket only during publishing if configured #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #139 and fixes the implementation of #135.
Issue:
Currently, the connection setting added in #135 has no effect due to a typo in the assignment.
Background:
Due to the nature of MQTT and how network communication works, non-blocking mode for sockets is quite essential when reading data received from the MQTT broker. If such reads are performed in blocking mode and no data is received from the broker over a long period of time, the connection may timeout.
Solution:
This PR fixes the typo in the connection settings. Because this fix introduces an issue when blocking mode is used for the socket, the meaning of the setting has been changed slightly. It now only affects the publishing of messages and is not used for reads on the socket.