Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PHP8 appreciate for new workshop version #49

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update PHP8 appreciate for new workshop version #49

wants to merge 8 commits into from

Conversation

AydinHassan
Copy link
Member

No description provided.

@AydinHassan
Copy link
Member Author

@mikeymike only a few failures 😱 the fix for the big issue with bind mounts was this: https://github.com/php-school/php-workshop/pull/300/files#diff-b8aa8129dc6b9ec2a602a608dfce32dfecafdfb0e1579d49cfb79076ffbc8521L60 - no idea why, I just randomly commented it out and it started working. Locally I have 2 failures and it seems like a timing issue because when I run the failing ones on it's own it works fine.

But we pretty close now!

@AydinHassan
Copy link
Member Author

The two failures on LordOfTheStrings must be because it's a composer exercise. I would hazard a guess the vendor dir is created with different permissions/ownership inside the container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AydinHassan