Extract autoEncryption driver options in MongoDB\Driver\Manager::__construct()
#4754
Conversation
GromNaN
force-pushed
the
flat-autoEncryption
branch
3 times, most recently
from
5ca64a5 to
dbba6f6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
GromNaN
force-pushed
the
flat-autoEncryption
branch
from
dbba6f6 to
34e1c54
Compare
language-snippets.ent
Outdated
| <entry><classname>MongoDB\Driver\Manager</classname></entry> | ||
| <entry>The Manager used to route data key queries to a separate MongoDB cluster. By default, the current Manager and cluster is used.</entry> | ||
| </row> | ||
| <entry xmlns="http://docbook.org/ns/docbook">The Manager used to route data key queries to a separate MongoDB cluster. By default, the current Manager and cluster is used.</entry> |
There was a problem hiding this comment.
Indentation looks off by one space here and all other snippets.
| @@ -659,129 +659,6 @@ mongodb://[username:password@]host1[:port1][,host2[:port2],...[,hostN[:portN]]][ | |||
| <literal>bypassAutoEncryption</literal> is &true;. | |||
| </para> | |||
| </note> | |||
| <para> | |||
There was a problem hiding this comment.
Would it make sense to add a note that these are explained separately below? We could also close out the current <table> and <para>, then add a new <para> with a title of "Auto encryption options" to create a separate table for them. That table could specifies that "these keys are available in the autoEncryption driver option, which would allow you to skip refactoring of the language snippets.
There was a problem hiding this comment.
I reworked the PR to create a new table and keep the full row entities.
GromNaN
force-pushed
the
flat-autoEncryption
branch
from
34e1c54 to
dd2f36e
Compare
| @@ -636,7 +636,7 @@ mongodb://[username:password@]host1[:port1][,host2[:port2],...[,hostN[:portN]]][ | |||
| <entry> | |||
| <para> | |||
| Provides options to enable automatic client-side field level | |||
| encryption. | |||
| encryption. The list of options is described in the table below. | |||
There was a problem hiding this comment.
I would like to add a link to a reference in the page.
| Options supported by automatic encryption: | ||
| <table> | ||
| <title>autoEncryption</title> | ||
| <tgroup cols="3"> |
There was a problem hiding this comment.
I could add this to set the column widths, but this is not using % anywhere.
| <tgroup cols="3"> | |
| <tgroup cols="3"> | |
| <colspec colwidth="25%" colname="option"/> | |
| <colspec colwidth="10%" colname="type"/> | |
| <colspec colwidth="65%" colname="description"/> |
In few places it's using 2* notation that is not handled by the website.
doc-en/reference/yaz/functions/yaz-hits.xml
Lines 61 to 63 in c21abf2
The website CSS should use table-layout: auto instead of fixed so that the column width are adjusted automatically.
GromNaN
changed the title
autoEncryption driver options in MongoDB\Driver\Manager::__construct()autoEncryption driver options in MongoDB\Driver\Manager::__construct()
Fix the
$driverOptionsparameter table this page to prevent unreadable nested array: https://www.php.net/manual/en/mongodb-driver-manager.construct.php#mongodb-driver-manager.construct-driveroptionsThis page is not modified: https://www.php.net/manual/en/mongodb-driver-manager.createclientencryption.php
Question: I would like to optimize the column width to give more space to the description.
https://jira.mongodb.org/browse/PHPC-2573