Skip to content

Add macos 15 to push GH action #18514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jorgsowa
Copy link
Contributor

@jorgsowa jorgsowa commented May 7, 2025

Adds Macos15 to push GH action. Or maybe I should replace it with and add 14 to nightly?

@jorgsowa jorgsowa requested a review from TimWolla as a code owner May 7, 2025 17:25
@nielsdos
Copy link
Member

nielsdos commented May 7, 2025

Interesting how CI now also runs into #18324
I don't have a system to test this with though.

@iluuu1994
Copy link
Member

Thanks! I don't think we need both 15 and 14 for push, I'd be in favor of upgrading to 15. The same should be done for nightly.

@jorgsowa jorgsowa force-pushed the ci/add-macos3-push branch from b70198e to d7474e5 Compare May 14, 2025 15:04
@jorgsowa
Copy link
Contributor Author

Because of the issue that is in ctype ext in macos15 I moved changes to nightly to separate PR and left here only changes to push job.
#18554

@iluuu1994
Copy link
Member

Because of the issue that is in ctype ext in macos15 I moved changes to nightly to separate PR and left here only changes to push job.

Merging the nightly PR will make nightly fail, so we should fix the test first in either case. Unfortunately, I'm not of much help in that regard...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants