Skip to content

Remove zend_get_zendleng() declaration #19032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2025
Merged

Remove zend_get_zendleng() declaration #19032

merged 2 commits into from
Jul 4, 2025

Conversation

DanielEScherzer
Copy link
Member

Does not actually exist anywhere

@DanielEScherzer
Remove zend_get_zendleng() declaration
4e1e86a 
Does not actually exist anywhere
iluuu1994
iluuu1994 approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. IMO, the UPGRADING.INTERNALS is not needed, as code using it would already have been broken. So it just adds noise.

@DanielEScherzer DanielEScherzer merged commit 3558293 into php:master Jul 4, 2025
1 check passed
@DanielEScherzer DanielEScherzer deleted the no-zend_get_zendleng branch July 4, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees
No one assigned
Labels
ABI break Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielEScherzer @iluuu1994