Use consistent type for h on call zend_hash_index_* #19255
+42
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zend_hash_index_*
expectszend_ulong
for theh
argument but often this argument got casted tozend_long
(instead ofzend_ulong
.Additionally, most of the time, a pointer first got casted to
(uintptr_t)
before(zend_ulong)
but sometimes a pointer got casted directly. I noticed this during my work of #19079 as it fails if the pointer size andzend_ulong
differs.