Skip to content

Deprecate driver specific PDO constants #19526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Deprecate driver specific PDO constants #19526

wants to merge 3 commits into from
+636 −348

Conversation

arnaud-lb
Copy link
Member

This implements the "Deprecate driver specific PDO constants" part of https://wiki.php.net/rfc/deprecations_php_8_5.

I will handle methods in a separate PR.

@arnaud-lb arnaud-lb mentioned this pull request Aug 20, 2025
Open
17 tasks
@devnexen
Copy link
Member

Note I did an attempt for the Pdo/Pgsql transaction part.

@arnaud-lb arnaud-lb marked this pull request as ready for review August 20, 2025 14:40
@arnaud-lb arnaud-lb requested a review from a team August 20, 2025 15:43
Girgias
Girgias approved these changes Aug 23, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bukka bukka requested review from a team and removed request for a team, bukka and SakiTakamachi August 23, 2025 16:03
edorian
edorian approved these changes Aug 24, 2025
View reviewed changes
Copy link
Member

@edorian edorian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RM approval for 8.5 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edorian edorian edorian approved these changes

@NattyNarwhal NattyNarwhal NattyNarwhal approved these changes

@Girgias Girgias Girgias approved these changes

@devnexen devnexen Awaiting requested review from devnexen devnexen is a code owner

@kamil-tekiela kamil-tekiela Awaiting requested review from kamil-tekiela kamil-tekiela is a code owner

Assignees
No one assigned
Labels
ABI break Extension: mysqli Extension: mysqlnd Extension: pdo (core) Extension: pdo_dblib Extension: pdo_firebird Extension: pdo_mysql Extension: pdo_odbc Extension: pdo_pgsql Extension: pdo_sqlite RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arnaud-lb @devnexen @edorian @NattyNarwhal @Girgias @DanielEScherzer