Share common markup for PHP 8.0 release page translations #1530
Conversation
theodorejb
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
theodorejb
force-pushed
the
simplify-8.0-translations
branch
from
bb8969f to
7804a3d
Compare
|
Thank you for your contribution, but I don't think it's necessary to modify the 8.0 version. We're currently pushing forward with the new design for 8.5. |
|
My goal wasn't to modify it, but to structure it the same as the other release pages for ease of maintainability. As part of this I found a bunch of bugs and inconsistencies which could be fixed at the same time. |
theodorejb
force-pushed
the
simplify-8.0-translations
branch
2 times, most recently
from
b6b11d4 to
5b70726
Compare
|
Does anything prevent merging this? The only content change now is adding |
|
🚀 Preview for commit b0c6afa can be found at https://web-php-pr-1530.preview.thephp.foundation |
|
🚀 Regression report for commit b0c6afa is at https://web-php-regression-report-pr-1530.preview.thephp.foundation |
|
We need to update the screenshots in testing. Perhaps @saundefined can assist. |
Adds a `release.inc` file for PHP 8.0 like the other release pages have, in order to avoid duplicating all the markup for every translation (making it much easier to maintain consistent content). Apart from the following exceptions, no content or translations have been changed:
Consistency improvements:
* Added IDs to headings in section above footer for direct linking (like the other release pages have).
* Added `<code>` tag around operators and keywords for better readability (the other release pages do this).
* Updated code examples to consistently use 4-space indentation (previously the attributes code example used four spaces and others used two spaces).
Translation-specific fixes:
* Fixed bug where heading links in the French and Japanese translations unexpectedly switched to the English translation of the page (caused by incorrect `$_SERVER['BASE_PAGE']` value).
* Spanish, Italian, and Turkish pages previously incorrectly linked to English documentation for some or all of the documentation links.
* French translation previously had a different code example for attributes, which didn't really make sense (it showed the same `/api/posts/{id}` Route attribute, but above a User class rather than on a `get` method in a PostsController class).
* Fixed incorrect Static Return Type RFC link in Portuguese translation.
* Fixed a couple minor spacing bugs in Spanish translation.
* Chinese page previously was missing translation for Documentation link in a couple places.
* Fixed missing blank lines in a few Chinese translation code blocks.
* Fixed inconsistent strings in Georgian match expression example.
theodorejb
force-pushed
the
simplify-8.0-translations
branch
from
5b70726 to
eccf9f9
Compare
|
@sy-records I updated the screenshot now. |
3 participants
Adds a
release.incfile for PHP 8.0 like the other release pages have, in order to avoid duplicating all the markup for every translation (making it much easier to maintain consistent content). Apart from the following exceptions, no content or translations have been changed:Consistency improvements
<code>tag around operators and keywords for better readability (the other release pages do this).Translation-specific fixes
$_SERVER['BASE_PAGE']value)./api/posts/{id}Route attribute, but above a User class rather than on agetmethod in a PostsController class).In a second commit, I also fixed broken documentation links on the PHP 8.1 Georgian translation.