Change default character set from UTF8 to UTF8MB4 #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to allow emojis and other extended character sets, database tables need to be updated to use UTF8MB4, which seems to work well within the phpList app proper. The API using UTF8 encoding prevents extended characters from being stored in the database tables. As I believe UTF8MB4 is a superset of UTF8, this change does not impact installations using UTF8, but does allow those with UTF8MB4 access to the full set of allowed characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow emojis and other extended character sets, database tables need to be updated to use UTF8MB4, which seems to work well within the phpList app proper.
The API using UTF8 encoding prevents extended characters from being stored in the database tables.
As I believe UTF8MB4 is a superset of UTF8, this change does not impact installations using UTF8, but does allow those with UTF8MB4 access to the full set of allowed characters.