Fixing memory leaks and deprecations#545
Merged
Merged
Conversation
Member
|
@redbullmarky once more thank you for the sustained effort you're putting in this. |
standa
added a commit
to standa/php-v8js
that referenced
this pull request
Jun 4, 2026
Declares the extension as type=php-ext so pie.phar (PHP Installer for
Extensions) can install it directly, and so the package is discoverable
on Packagist as phpv8/v8js.
Key fields:
- extension-name: v8js — the loaded extension name. (Set explicitly
rather than auto-derived from the Composer package name, in case the
vendor/package shape changes in the future.)
- configure-options: [{name: with-v8js, needs-value: true}] — mirrors
the single --with-v8js[=DIR] macro in config.m4.
- download-url-method: [pre-packaged-binary, composer-default] — when
prebuilt .so assets are attached to a release (see the new release.yml
workflow), PIE downloads those; otherwise it falls back to a Composer-
default git-archive source build.
- os-families-exclude: [windows] — Windows support would require
prebuilt DLLs via php/php-windows-builder; not part of this change.
- require.php: ^8.1 — matches what this branch supports after PR phpv8#545.
PHP 8.0 is EOL (Nov 2023).
No source files are touched; this is a packaging-only addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one has fixes for a few outstanding items, generally relating to memory leaks or deprecations/compatibility.
zend_exception_get_default(). Code updated to usezend_ce_exception(), available since PHP7.0. Fixes php 8.5 compile error - zend_exception_get_default not declared #544Holder()→This(). No specific issue open afaik, but this one was stopping us building.All tests pass (as do our own, and we have a fair few, albeit coving specific weird edge cases and things specific to the way we do things). Hopefully this is ok, @stesie ? Hoping to look at a few more too and (finally) perhaps look at the 3.0.0 thing. We've been building against V8 AND libnode, both working well, so perhaps I can get some of the docs polished in the next batch.