Skip to content

Conversation

@smoia
Copy link
Member

@smoia smoia commented Aug 5, 2025

Closes #

Proposed Changes

  • Add a brand new cluster estimation to find groups of triggers, i.e. takes or runs.
  • Actually allow SMR (Spike2) files to be processed by phys2bids.
  • Also update workflows since I'm there.

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia self-assigned this Aug 5, 2025
@github-actions github-actions bot added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Aug 5, 2025
@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 11.11111% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.83%. Comparing base (63c3d83) to head (3e5bea3).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
phys2bids/slice4phys.py 1.69% 58 Missing ⚠️
phys2bids/phys2bids.py 28.57% 5 Missing ⚠️
phys2bids/physio_obj.py 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   91.15%   85.83%   -5.32%     
==========================================
  Files           8        8              
  Lines        1006     1073      +67     
==========================================
+ Hits          917      921       +4     
- Misses         89      152      +63     
Files with missing lines Coverage Δ
phys2bids/cli/run.py 96.66% <100.00%> (+0.23%) ⬆️
phys2bids/utils.py 98.09% <100.00%> (ø)
phys2bids/physio_obj.py 94.06% <66.66%> (ø)
phys2bids/phys2bids.py 84.97% <28.57%> (-2.20%) ⬇️
phys2bids/slice4phys.py 37.11% <1.69%> (-55.00%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@smoia smoia added the Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) label Aug 5, 2025
@smoia smoia moved this to PR needs review in Physiopy Oct 16, 2025
@smoia smoia added this to Physiopy Oct 16, 2025
help="Run automatic algorithm to estimate clusters of triggers, i.e. the "
"'takes' or 'runs' of fMRI. Useful when sequences were stopped and restarted, "
"or when you don't know how many triggers or trs you have in each take. "
"This might work 95%% of the time. Default is False.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This might work 95%% of the time" is a funny sentence! Can we be clearer on why it may not? Or can we say something like "please check this output/plot carefully to see if it has done X task correctly"

Raises
------
Exception
If it doesn't find at least a group.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If it doesn't find at least a group.
If it doesn't find at least one group.

@RayStick
Copy link
Member

RayStick commented Oct 22, 2025

  • Changes to the workflow files and setup.cfg look fine
  • Changes to the others files - I have read them over, but not run anything. Would you like me to run it? If yes, can you point me towards some files to test with? Including how you ran them
  • Assuming we need to update the tests for the coverage to be happy? If I can understand the function better, I can try to help with updating the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0)

Projects

Status: PR needs review

Development

Successfully merging this pull request may close these issues.

2 participants