-
Notifications
You must be signed in to change notification settings - Fork 48
Add an automatic algorithm to find group of triggers, i.e. "takes" or "runs", and attempt splitting recording automagically. #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
==========================================
- Coverage 91.15% 85.83% -5.32%
==========================================
Files 8 8
Lines 1006 1073 +67
==========================================
+ Hits 917 921 +4
- Misses 89 152 +63
🚀 New features to boost your workflow:
|
…ng about why it works.
| help="Run automatic algorithm to estimate clusters of triggers, i.e. the " | ||
| "'takes' or 'runs' of fMRI. Useful when sequences were stopped and restarted, " | ||
| "or when you don't know how many triggers or trs you have in each take. " | ||
| "This might work 95%% of the time. Default is False.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This might work 95%% of the time" is a funny sentence! Can we be clearer on why it may not? Or can we say something like "please check this output/plot carefully to see if it has done X task correctly"
| Raises | ||
| ------ | ||
| Exception | ||
| If it doesn't find at least a group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| If it doesn't find at least a group. | |
| If it doesn't find at least one group. |
|
Closes #
Proposed Changes
Change Type
bugfix(+0.0.1)minor(+0.1.0)major(+1.0.0)refactoring(no version update)test(no version update)infrastructure(no version update)documentation(no version update)otherChecklist before review