Skip to content

allow SelectRaw with Readable #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

allow SelectRaw with Readable #742

wants to merge 2 commits into from

Conversation

@dantownsend
Copy link
Member

@dantownsend dantownsend commented Dec 30, 2022

Resolves #741

@dantownsend dantownsend added the enhancement New feature or request label Dec 30, 2022
@dantownsend dantownsend mentioned this pull request Dec 30, 2022
Open
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022 •
edited
Loading

Codecov Report

Merging #742 (02fbd6e) into master (fdb703f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #742   +/-   ##
=======================================
  Coverage   91.30%   91.30%           
=======================================
  Files         108      108           
  Lines        7383     7386    +3     
=======================================
+ Hits         6741     6744    +3     
  Misses        642      642
Impacted Files Coverage Δ
piccolo/apps/playground/commands/run.py 45.66% <100.00%> (+0.43%) ⬆️
piccolo/columns/readable.py 92.00% <100.00%> (+0.33%) ⬆️
piccolo/table.py 96.39% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sinisaos
sinisaos approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@sinisaos sinisaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks and works great.

@dantownsend
Copy link
Member Author

dantownsend commented Dec 30, 2022

@sinisaos Thanks. I'll add a couple more tests and docs, and will merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sinisaos sinisaos sinisaos approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make Readable for boolean fields more user-friendly

4 participants

@dantownsend @codecov-commenter @sinisaos