-
Notifications
You must be signed in to change notification settings - Fork 43
Changes toolAggregate to allow for but remove empty mapping targets #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes toolAggregate to allow for but remove empty mapping targets #278
Conversation
|
I think a note would be indeed useful. |
18c7892 to
b24e326
Compare
b24e326 to
81753bc
Compare
|
Something is off. I have already implemented the |
…/madrat into feature/empty-mapping-targets
|
Found the missing commit, will squash on merge to remove the weird history. |
…ange the working directory
File-Locking of PUCs to prevent corrupt PUC files
tscheypidi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Just as a side note: you could probably write lines 506 - 512 more compact using the dim argument in magclass objects, e.g. something like m <- m[emptyValues, dim = i, invert = TRUE]
…/madrat into feature/empty-mapping-targets
Ah, perfect, I was looking for something like this, but was not aware of that! Also: This is such a convoluted PR commit log for such a small code change 😄 |
Open questions:
TODOs:
notethat there were empty cells, which will be ignored in the output?