File-Locking of PUCs to prevent corrupt PUC files #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascal-sauer
requested changes
Jan 9, 2026
Contributor
pascal-sauer
left a comment
pascal-sauer
left a comment
There was a problem hiding this comment.
buildLibrary is still missing.
Thanks for (hopefully 🤞 ) fixing the corrupt puc issue! Plus you implemented a tricky test 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is described in more detail under this issue (internal link)
Essentially, when multiple madrat jobs are started that all want to write the same PUC, they might end up doing it simultaneously. This PR prevents that and also prevents reading a PUC that was not completely written yet (although that is much more unlikely, it may still occur, when the file is already present but not yet fully written).
Open todos: