Adjust naming to match naming of other pimcore bundles #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Pfahlbusch <[email protected]>
Signed-off-by: Dennis Pfahlbusch <[email protected]>
ghost
added
the
|
@dpfahlbusch Thank you for this contribution. This is considered a BC Break, since you also have to change your bundles.php or your registerDependentBundles method. We can only do this in a new major version. |
|
@dpfahlbusch I created a 3.x branch and switched the base branch of your PR. |
added 2 commits
February 28, 2025 11:56
Signed-off-by: Dennis Pfahlbusch <[email protected]>
|
Done @mattamon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dennis Pfahlbusch [email protected]